LPS-124430 Saves tooltip trigger title on show events #629

jbalsas · 2020-12-17T10:00:38Z

From the commit itself:

Before, the change of title to data-restore-title happened based on the component rendering and state, making it fail to execute under certain conditions.

With this change, anytime the mouse moves over a tooltip trigger, its title attribute is moved to a data-restore-title attribute avoiding unnecessary rendering of the native tooltip.

The effect can be seen in this screencast and it happened to all tooltips in DXP:

The Problem
To take over the native tooltips, we move title attributes to data-restore-title when we enter a trigger element. This attribute is then restored back to title when we abandon it.

Previous logic depended on a useEffect(... [target]) and some internal conditions to execute the saveTitle method while restoreTitle was running unconditionally when the trigger was abandoned (like to move into the tooltip).

The Fix
We simply move the saveTitle execution to the initial show trigger. This means there are more DOM changes but the DOM state remains consistent through interactions.

Test Plan

Hover over an icon in DXP and wait until the tooltip shows
Move the mouse over the tooltip
Move it back over the icon
Wait for the native tooltip to appear

Additional Reference
Just because I've kept this around all this time, in case someone goes into the implementation and wonders what's with all the craziness... this is the tooltip state diagram:

liferay-continuous-integration · 2020-12-17T10:00:43Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2020-12-17T10:04:56Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ff0e5e147ea14773fc626b3a4024d041bfefb138

Sender Branch:

Branch Name: LPS-124430
Branch GIT ID: 5c75543df5642a85527c0c2e2fbb826f7a2f0001

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

Before, the change of `title` to `data-restore-title` happened based on the component rendering and state, making it fail to execute under certain conditions. With this change, anytime the mouse moves over a tooltip trigger, its `title` attribute is moved to a `data-restore-title` attribute avoiding unnecessary rendering of the native tooltip.

jbalsas · 2020-12-17T10:05:42Z

ci:stop

jbalsas · 2020-12-17T10:06:07Z

I somehow managed to mangle a one-line commit 🙈

jbalsas · 2020-12-17T10:06:19Z

ci:stop

liferay-continuous-integration · 2020-12-17T10:07:06Z

						<h1>Unable to generate test report.</h1><p>Jenkins encountered the following error while generating test report:</p><pre><code>Sourced file: inline evaluation of: `` 						 							import com.liferay.jenkins.results.parser.Build; 							import co . . . '' : TargetError : at Line: 48 : in file: inline evaluation of: `` 						 							import com.liferay.jenkins.results.parser.Build; 							import co . . . '' : throw e ;

Target exception: java.lang.RuntimeException: Unable to find properties for git.portal.properties

Base Branch:

Branch Name: master

Branch GIT ID: ff0e5e147ea14773fc626b3a4024d041bfefb138

Job Summary:

Job Link: test-portal-acceptance-pullrequest(master)

For more details click here.

jbalsas · 2020-12-17T10:09:33Z

ci:test:sf

jbalsas · 2020-12-17T10:09:39Z

ci:test:relevant

liferay-continuous-integration · 2020-12-17T10:09:58Z

Jenkins Build:test-portal-source-format#3864
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#629
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - jbalsas > liferay-frontend - PR#629 - 2020-12-17[02:00:55]
Spira Jenkins Build:publish-spira-report#16518

julien · 2020-12-17T10:12:53Z

@jbalsas the other day between two tasks, I saw this one on the issue board and have the exact same change in a branch

julien · 2020-12-17T10:13:32Z

@jbalsas how did you generate that diagram?

jbalsas · 2020-12-17T10:15:41Z

@jbalsas the other day between two tasks, I saw this one on the issue board and have the exact same change in a branch

Next time assign the issue to yourself then so we know someone's looking at it! 👀

@jbalsas how did you generate that diagram?

I can't quite remember 😂

liferay-continuous-integration · 2020-12-17T10:22:21Z

Jenkins Build:test-portal-source-format#2194
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#629
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - jbalsas > liferay-frontend - PR#629 - 2020-12-17[02:10:09]
Spira Jenkins Build:publish-spira-report#16522

wincent · 2020-12-17T12:08:53Z

Top Giphy result for "state machines":

liferay-continuous-integration · 2020-12-17T12:35:29Z

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 23 jobs passed in 2 hours 22 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ff0e5e147ea14773fc626b3a4024d041bfefb138

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 0ff04d9f73a4643abdd2b335581feef26b985b8a

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 20 out of 23 jobs PASSED

3 Failed Jobs:

20 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
37 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=2,label_exp=!master #429662
  1. LocalFile.CPCommerceSettings#ViewInstanceCurrenciesAvailable - Poshi Report - Poshi Summary - Console Output

Failures in common with acceptance upstream results at 39cc3ed:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #447503

Please fix semantic versioning on jbalsas/LPS-124430

     [exec] 			+   return     void
     [exec] 		+   method     <init>(java.lang.String)
     [exec] 			+   return     void
     [exec] 		+   method     <init>(java.lang.String,java.lang.Throwable)
     [exec] 			+   return     void
     [exec] 		+   method     <init>(java.lang.Throwable)
     [exec] 			+   return     void
     [exec] 		+   method     addSuppressed(java.lang.Throwable)
     [exec] 			+   access     final
     [exec] 			+   return     void
     [exec] 		+   method     clone()
     [exec] 			+   access     protected
     [exec] 			+   return     java.lang.Object
     [exec] 		+   method     equals(java.lang.Object)
     [exec] 			+   return     boolean
     [exec] 		+   method     fillInStackTrace()
     [exec] 			+   return     java.lang.Throwable
     [exec] 		+   method     finalize()
     [exec] 			+   access     protected
     [exec] 			+   return     void
     [exec] 		+   method     getCause()
     [exec] 			+   return     java.lang.Throwable
     [exec] 		+   method     getLocalizedMessage()
     [exec] 			+   return     java.lang.String
     [exec] 		+   method     getMessage()
     [exec] 			+   return     java.lang.String
     [exec] 		+   method     getStackTrace()
     [exec] 			+   return     java.lang.StackTraceElement[]
     [exec] 		+   method     getSuppressed()
     [exec] 			+   access     final
     [exec] 			+   return     java.lang.Throwable[]
     [exec] 		+   method     hashCode()
     [exec] 			+   return     int
     [exec] 		+   method     initCause(java.lang.Throwable)
     [exec] 			+   return     java.lang.Throwable
     [exec] 		+   method     printStackTrace()
     [exec] 			+   return     void
     [exec] 		+   method     printStackTrace(java.io.PrintStream)
     [exec] 			+   return     void
     [exec] 		+   method     printStackTrace(java.io.PrintWriter)
     [exec] 			+   return     void
     [exec] 		+   method     setStackTrace(java.lang.StackTraceElement[])
     [exec] 			+   return     void
     [exec] 		+   method     toString()
     [exec] 			+   return     java.lang.String
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/9.18.0/471e51c2d8cc477362ba9dd7449b8c3974545660/com.liferay.portal.kernel-9.18.0.jar

jbalsas · 2020-12-17T12:46:30Z

I don't see how that test can be related... let's give this another 2 and a half hours of our lives just to be sure!

jbalsas · 2020-12-17T12:46:34Z

ci:test:relevant

liferay-continuous-integration · 2020-12-17T12:57:10Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#4002
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#629
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - jbalsas > liferay-frontend - PR#629 - 2020-12-17[02:10:09]
Spira Jenkins Build:publish-spira-report#10331

wincent · 2020-12-17T13:21:53Z

I don't see how that test can be related... let's give this another 2 and a half hours of our lives just to be sure!

liferay-continuous-integration · 2020-12-17T15:05:52Z

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 23 jobs passed in 1 hour 54 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ff0e5e147ea14773fc626b3a4024d041bfefb138

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 0ff04d9f73a4643abdd2b335581feef26b985b8a

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 20 out of 23 jobs PASSED

3 Failed Jobs:

20 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
37 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=2,label_exp=!master #481947
  1. LocalFile.CPCommerceSettings#ViewInstanceCurrenciesAvailable - Poshi Report - Poshi Summary - Console Output

Failures in common with acceptance upstream results at 6f7122e:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #459052

Please fix semantic versioning on jbalsas/LPS-124430

     [exec] 			+   return     void
     [exec] 		+   method     <init>(java.lang.String)
     [exec] 			+   return     void
     [exec] 		+   method     <init>(java.lang.String,java.lang.Throwable)
     [exec] 			+   return     void
     [exec] 		+   method     <init>(java.lang.Throwable)
     [exec] 			+   return     void
     [exec] 		+   method     addSuppressed(java.lang.Throwable)
     [exec] 			+   access     final
     [exec] 			+   return     void
     [exec] 		+   method     clone()
     [exec] 			+   access     protected
     [exec] 			+   return     java.lang.Object
     [exec] 		+   method     equals(java.lang.Object)
     [exec] 			+   return     boolean
     [exec] 		+   method     fillInStackTrace()
     [exec] 			+   return     java.lang.Throwable
     [exec] 		+   method     finalize()
     [exec] 			+   access     protected
     [exec] 			+   return     void
     [exec] 		+   method     getCause()
     [exec] 			+   return     java.lang.Throwable
     [exec] 		+   method     getLocalizedMessage()
     [exec] 			+   return     java.lang.String
     [exec] 		+   method     getMessage()
     [exec] 			+   return     java.lang.String
     [exec] 		+   method     getStackTrace()
     [exec] 			+   return     java.lang.StackTraceElement[]
     [exec] 		+   method     getSuppressed()
     [exec] 			+   access     final
     [exec] 			+   return     java.lang.Throwable[]
     [exec] 		+   method     hashCode()
     [exec] 			+   return     int
     [exec] 		+   method     initCause(java.lang.Throwable)
     [exec] 			+   return     java.lang.Throwable
     [exec] 		+   method     printStackTrace()
     [exec] 			+   return     void
     [exec] 		+   method     printStackTrace(java.io.PrintStream)
     [exec] 			+   return     void
     [exec] 		+   method     printStackTrace(java.io.PrintWriter)
     [exec] 			+   return     void
     [exec] 		+   method     setStackTrace(java.lang.StackTraceElement[])
     [exec] 			+   return     void
     [exec] 		+   method     toString()
     [exec] 			+   return     java.lang.String
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/9.18.0/471e51c2d8cc477362ba9dd7449b8c3974545660/com.liferay.portal.kernel-9.18.0.jar

jbalsas · 2020-12-17T15:07:45Z

@john-co, @PablitoBonito could you see if this related after all? Failed twice in a row, so it's either that or already broken upstream 🤔

liferay-continuous-integration · 2020-12-17T15:21:32Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#4003
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#629
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - jbalsas > liferay-frontend - PR#629 - 2020-12-17[05:10:04]
Spira Jenkins Build:publish-spira-report#9682

jbalsas · 2020-12-17T17:30:15Z

Same issue also seen at #636, so forwarding manually!

jbalsas · 2020-12-17T17:31:48Z

Forwarded at brianchandotcom#97047

wincent · 2020-12-17T18:05:54Z

And #632 → brianchandotcom#97050

john-co · 2020-12-17T20:07:24Z

Reviewed. Test failures are unrelated. ✔️

Confirmed issue already exists in upstream: https://liferay.spiraservice.net/16/TestCase/191632.aspx

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Dec 17, 2020

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending labels Dec 17, 2020

liferay-continuous-integration added ci:test:relevant - failure and removed ci:test:relevant - pending labels Dec 17, 2020

jbalsas force-pushed the LPS-124430 branch from 5c75543 to 4cc9ca4 Compare December 17, 2020 10:06

julien approved these changes Dec 17, 2020

View reviewed changes

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending and removed ci:test:sf - success ci:test:relevant - failure ci:test:stable - pending labels Dec 17, 2020

liferay-continuous-integration added ci:test:sf - success and removed ci:test:sf - pending labels Dec 17, 2020

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Dec 17, 2020

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending and removed ci:test:relevant - failure ci:test:stable - success labels Dec 17, 2020

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Dec 17, 2020

jbalsas mentioned this pull request Dec 17, 2020

LPS-124465 Avoid unwanted minification of Liferay global #636

Closed

jbalsas mentioned this pull request Dec 17, 2020

LPS-124430 Saves tooltip trigger title on show events brianchandotcom/liferay-portal#97047

Closed

jbalsas closed this Dec 17, 2020

jbalsas deleted the LPS-124430 branch September 14, 2021 08:35

LPS-124430 Saves tooltip trigger title on show events #629

LPS-124430 Saves tooltip trigger title on show events #629

Conversation

jbalsas commented Dec 17, 2020 • edited

liferay-continuous-integration commented Dec 17, 2020

liferay-continuous-integration commented Dec 17, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

jbalsas commented Dec 17, 2020

jbalsas commented Dec 17, 2020

jbalsas commented Dec 17, 2020

liferay-continuous-integration commented Dec 17, 2020

Base Branch:

Job Summary:

jbalsas commented Dec 17, 2020

jbalsas commented Dec 17, 2020

liferay-continuous-integration commented Dec 17, 2020

julien commented Dec 17, 2020

julien commented Dec 17, 2020

jbalsas commented Dec 17, 2020

liferay-continuous-integration commented Dec 17, 2020

wincent commented Dec 17, 2020

liferay-continuous-integration commented Dec 17, 2020

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 23 jobs passed in 2 hours 22 minutes

Base Branch:

Copied in Private Modules Branch:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

jbalsas commented Dec 17, 2020

jbalsas commented Dec 17, 2020

liferay-continuous-integration commented Dec 17, 2020

wincent commented Dec 17, 2020

liferay-continuous-integration commented Dec 17, 2020

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 23 jobs passed in 1 hour 54 minutes

Base Branch:

Copied in Private Modules Branch:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

jbalsas commented Dec 17, 2020

liferay-continuous-integration commented Dec 17, 2020

jbalsas commented Dec 17, 2020

jbalsas commented Dec 17, 2020

wincent commented Dec 17, 2020

john-co commented Dec 17, 2020

jbalsas commented Dec 17, 2020 •

edited