[TS] LPS-125037 Apply button in Filter by Field panel is not shown correctly after trying to modify the value that we set earlier #638

bakayattila · 2020-12-17T16:57:22Z

hi Team,
Could you please review this pull request?
https://issues.liferay.com/browse/LPS-125037

best,
Attila

Steps

Setup Liferay DXP 7.2 with
Create a new structure with a Text field
Create a new web content with the structure
In the field
On the Home page add an Asset Publisher
Go to the configuration panel of the Asset Publisher→Display Settings
Asset Selection: Dynamic
Asset Type: Web Content Article
Web Content Article Structures: Basic Web Content
Filter by Field: YES
Click on Select
Check the new form

Expected Behavior
Only the apply button of the selected radio button is enabled

Actual Behavior
All the apply buttons enabled

The main reason behind the null check here is to prevent unnecessary modification on any form that is not related to asset selection.

…here there is no selectedData in the config

liferay-continuous-integration · 2020-12-17T16:57:27Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2020-12-17T17:05:15Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 8 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ff0e5e147ea14773fc626b3a4024d041bfefb138

Sender Branch:

Branch Name: LPS-125037
Branch GIT ID: c98f7abbefe679e577e0cf2e3fd4e09a1b1642c0

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2020-12-17T17:27:54Z

Jenkins Build:test-portal-source-format#4485
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#638
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - bakayattila > liferay-frontend - PR#638 - 2020-12-17[08:57:39]
Spira Jenkins Build:publish-spira-report#9699

liferay-continuous-integration · 2020-12-17T19:52:56Z

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 23 jobs passed in 2 hours 53 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ff0e5e147ea14773fc626b3a4024d041bfefb138

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 0ff04d9f73a4643abdd2b335581feef26b985b8a

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 20 out of 23 jobs PASSED

3 Failed Jobs:

20 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
37 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=2,label_exp=!master #211606
  1. LocalFile.CPCommerceSettings#ViewInstanceCurrenciesAvailable - Poshi Report - Poshi Summary - Console Output

Failures in common with acceptance upstream results at ff0e5e1:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #481963

Please fix semantic versioning on bakayattila/LPS-125037

     [exec] 			+   return     void
     [exec] 		+   method     <init>(java.lang.String)
     [exec] 			+   return     void
     [exec] 		+   method     <init>(java.lang.String,java.lang.Throwable)
     [exec] 			+   return     void
     [exec] 		+   method     <init>(java.lang.Throwable)
     [exec] 			+   return     void
     [exec] 		+   method     addSuppressed(java.lang.Throwable)
     [exec] 			+   access     final
     [exec] 			+   return     void
     [exec] 		+   method     clone()
     [exec] 			+   access     protected
     [exec] 			+   return     java.lang.Object
     [exec] 		+   method     equals(java.lang.Object)
     [exec] 			+   return     boolean
     [exec] 		+   method     fillInStackTrace()
     [exec] 			+   return     java.lang.Throwable
     [exec] 		+   method     finalize()
     [exec] 			+   access     protected
     [exec] 			+   return     void
     [exec] 		+   method     getCause()
     [exec] 			+   return     java.lang.Throwable
     [exec] 		+   method     getLocalizedMessage()
     [exec] 			+   return     java.lang.String
     [exec] 		+   method     getMessage()
     [exec] 			+   return     java.lang.String
     [exec] 		+   method     getStackTrace()
     [exec] 			+   return     java.lang.StackTraceElement[]
     [exec] 		+   method     getSuppressed()
     [exec] 			+   access     final
     [exec] 			+   return     java.lang.Throwable[]
     [exec] 		+   method     hashCode()
     [exec] 			+   return     int
     [exec] 		+   method     initCause(java.lang.Throwable)
     [exec] 			+   return     java.lang.Throwable
     [exec] 		+   method     printStackTrace()
     [exec] 			+   return     void
     [exec] 		+   method     printStackTrace(java.io.PrintStream)
     [exec] 			+   return     void
     [exec] 		+   method     printStackTrace(java.io.PrintWriter)
     [exec] 			+   return     void
     [exec] 		+   method     setStackTrace(java.lang.StackTraceElement[])
     [exec] 			+   return     void
     [exec] 		+   method     toString()
     [exec] 			+   return     java.lang.String
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/9.18.0/471e51c2d8cc477362ba9dd7449b8c3974545660/com.liferay.portal.kernel-9.18.0.jar

liferay-continuous-integration · 2020-12-17T20:27:17Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#8046
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#638
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - bakayattila > liferay-frontend - PR#638 - 2020-12-17[08:57:37]
Spira Jenkins Build:publish-spira-report#10357

jbalsas · 2020-12-21T14:57:12Z

Test error was flagged last week, so I'm going to rerun to see this green.

@bakayattila, while we wait to get confirmation from CI, could you please take some time to read through the following submission guidelines and update the PR with the suggestions below?

In summary, we'd appreciate if you could provide:

Descriptive title beyond a mere LPS ✅
Thorough description of the issue, things you tried, why you thing your solution is the right approach and any other considerations that might help us in our review 🔴
Test plan with simple steps to validate the issue (or get a feeling of how it has been validated by you) 🔴

I understand some of these might already be covered in the LPS itself, but having some of that data here helps us track it down and trace it when things move from user to user and allows us to focus on the review itself.

Thanks for your help in making this process better for everyone!! ❤️

jbalsas · 2020-12-21T14:57:26Z

ci:test:relevant

bakayattila · 2020-12-21T15:13:21Z

Hi @jbalsas , I updated the PR. I hope it is acceptable now.

jbalsas · 2020-12-21T15:25:34Z

Hi @jbalsas , I updated the PR. I hope it is acceptable now.

Thanks @bakayattila, appreciate the effort!! 🤗

The main reason behind the null check here is to prevent unnecessary modification on any form that is not related to asset selection.

This is the kind of information that is interesting and helps speed up the process! 😉

liferay-continuous-integration · 2020-12-21T16:41:24Z

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 23 jobs passed in 1 hour 42 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: dab7ad790ee947a2abc6cc6b656a1caa46943ac5

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 15218ef33680a1fe233ea812e8d097cfcb0feb42

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 21 out of 23 jobs PASSED

2 Failed Jobs:

21 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at dab7ad7:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

367 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #449788

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
HikariPool-1 - Connection is not available, request timed out after 600000ms.
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

jbalsas · 2020-12-21T17:21:53Z

I haven't tested this, but changes kinda make sense, so I'm going to take your word for it assuming you've done the proper manual testing since this is an old part of portal and automatic test coverage is not going to help us much.

Thanks!

jbalsas · 2020-12-21T17:21:59Z

ci:forward

liferay-continuous-integration · 2020-12-21T17:22:03Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2020-12-21T17:22:03Z

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2020-12-21T17:23:39Z

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

liferay-continuous-integration · 2020-12-21T17:24:05Z

Pull request has been successfully forwarded to brianchandotcom#97149

liferay-continuous-integration · 2020-12-21T19:04:13Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6497
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#638
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - bakayattila > liferay-frontend - PR#638 - 2020-12-21[06:57:38]
Spira Jenkins Build:publish-spira-report#10527

LPS-125037 use a proper null check to prevent modification in forms w…

c98f7ab

…here there is no selectedData in the config

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending labels Dec 17, 2020

bakayattila changed the title ~~[TS] LPS-125037~~ [TS] LPS-125037 Apply button in Filter by Field panel is not shown correctly after trying to modify the value that we set earlier Dec 17, 2020

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Dec 17, 2020

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Dec 17, 2020

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending and removed ci:test:relevant - failure ci:test:stable - success labels Dec 21, 2020

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Dec 21, 2020

liferay-continuous-integration mentioned this pull request Dec 21, 2020

[TS] LPS-125037 Apply button in Filter by Field panel is not shown correctly after trying to modify the value that we set earlier brianchandotcom/liferay-portal#97149

Closed

liferay-continuous-integration closed this Dec 21, 2020

[TS] LPS-125037 Apply button in Filter by Field panel is not shown correctly after trying to modify the value that we set earlier #638

[TS] LPS-125037 Apply button in Filter by Field panel is not shown correctly after trying to modify the value that we set earlier #638

Conversation

bakayattila commented Dec 17, 2020 • edited

liferay-continuous-integration commented Dec 17, 2020

liferay-continuous-integration commented Dec 17, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 8 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Dec 17, 2020

liferay-continuous-integration commented Dec 17, 2020

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 23 jobs passed in 2 hours 53 minutes

Base Branch:

Copied in Private Modules Branch:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

liferay-continuous-integration commented Dec 17, 2020

jbalsas commented Dec 21, 2020

jbalsas commented Dec 21, 2020

bakayattila commented Dec 21, 2020

jbalsas commented Dec 21, 2020

liferay-continuous-integration commented Dec 21, 2020

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 23 jobs passed in 1 hour 42 minutes

Base Branch:

Copied in Private Modules Branch:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

jbalsas commented Dec 21, 2020

jbalsas commented Dec 21, 2020

liferay-continuous-integration commented Dec 21, 2020

liferay-continuous-integration commented Dec 21, 2020

liferay-continuous-integration commented Dec 21, 2020

liferay-continuous-integration commented Dec 21, 2020

liferay-continuous-integration commented Dec 21, 2020

bakayattila commented Dec 17, 2020 •

edited