[TS] LPS-125881 Fix Liferay.Util.openWindow config title value

[rolandpakai]

Hi Team,

could you plesae check my fix and push it forward?

Thanks, Roland

https://issues.liferay.com/browse/LPS-125881

[liferay-continuous-integration]

CI is automatically triggering the following test suites:

•     ci:test:relevant
•     ci:test:sf

[liferay-continuous-integration]

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9abb5412f865531a30c879edc61e94795e419bce

Sender Branch:

Branch Name: LPS-125881-master
Branch GIT ID: f1424282a7612e68d57c29876e09a40c5fc8c49c

1 out of 1jobs PASSED

1 Successful Jobs:

• test-portal-source-format

For more details click here.

[liferay-continuous-integration]

Jenkins Build:test-portal-source-format#4178
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#702
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - rolandpakai > liferay-frontend - PR#702 - 2021-01-14[09:28:53]
Spira Jenkins Build:publish-spira-report#9773

[liferay-continuous-integration]

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 23 jobs passed in 1 hour 34 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9abb5412f865531a30c879edc61e94795e419bce

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 15218ef33680a1fe233ea812e8d097cfcb0feb42

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

• test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8_stable/0
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8_stable/0
• test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8_stable/0
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8_stable/0
• test-portal-acceptance-pullrequest-batch(master)/pmd-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/rest-builder-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/unit-jdk8_stable/0

ci:test:relevant - 23 out of 23 jobs PASSED

23 Successful Jobs:

• test-portal-acceptance-pullrequest(master)
• test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk11_open/0
• test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8_stable/0
• test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8_stable/0
• test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/modules-compile-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8_stable/0
• test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8_stable/0
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/pmd-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/rest-builder-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/unit-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/unit-jdk8_stable/0

For more details click here.

[liferay-continuous-integration]

Jenkins Build:test-portal-acceptance-pullrequest(master)#4130
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#702
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - rolandpakai > liferay-frontend - PR#702 - 2021-01-14[09:28:47]
Spira Jenkins Build:publish-spira-report#13253

[julien]

Hi @rolandpakai thanks for submitting this fix.

I tested the change and it does fix the issue described in LPS-125881 and the code change looks OK to me.

I'll let @carloslancha have a look at this too, the previous change was added in this commit which he submitted; and he might have something to say.

[rolandpakai]

Thank you @julien

I also found Carlos changes on LPS-62332
https://issues.liferay.com/browse/LPP-39994?focusedCommentId=2351833&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-2351833

[carloslancha]

Hey @rolandpakai I'm not sure right know why we went with   instead an empty string (long time since 2016 xD), probably something related with some styles breaking or some IE stuff if I have to bet.

Just check that everything is working as expected, if so this LGTM. Thx!!

[rolandpakai]

Thank you @carloslancha for checking the change.

Could you please push it forward?

Thanks, Roland

[julien]

Yes sure. we can

[julien]

ci:forward

[liferay-continuous-integration]

CI is automatically triggering the following test suites:

•     ci:test:relevant
•     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

•     ci:test:relevant
•     ci:test:sf
•     ci:test:stable

[liferay-continuous-integration]

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

[liferay-continuous-integration]

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

[liferay-continuous-integration]

Pull request has been successfully forwarded to brianchandotcom#97764