Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-157971 Use non ambiguous friendly urls for cross-group references #3256

Closed
wants to merge 2 commits into from
Closed

LPS-157971 Use non ambiguous friendly urls for cross-group references #3256

wants to merge 2 commits into from

Conversation

adolfopa
Copy link
Collaborator

No description provided.

@liferay-content-management
Copy link
Owner

ci:test:sf

@liferay-content-management
Copy link
Owner

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d365f9baded97fa9119cb07f5e0342304bf6c298

Sender Branch:

Branch Name: LPS-157971
Branch GIT ID: 48b62bbb100109d6d1c0c6d68975f3c3fbc7c176

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@adolfopa
Copy link
Collaborator Author

ci:stop

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 0 out of 1 jobs passed in 7 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d365f9baded97fa9119cb07f5e0342304bf6c298

Upstream Comparison:

Branch GIT ID: d365f9baded97fa9119cb07f5e0342304bf6c298
Jenkins Build URL: Acceptance Upstream DXP (master) #3545

ci:test:relevant - 0 out of 1 jobs PASSED
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    0 Jobs Passed.
    1 Job Failed.

    Build was aborted

For upstream results, click here.

@adolfopa
Copy link
Collaborator Author

ci:test:sf

@adolfopa
Copy link
Collaborator Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d365f9baded97fa9119cb07f5e0342304bf6c298

Sender Branch:

Branch Name: LPS-157971
Branch GIT ID: 87e45796a699df890a78751c6409d2364e873cf5

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@AliciaGarciaGarcia
Copy link
Collaborator

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

@brianchandotcom
Copy link

@adolfopa merged to master

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 27 out of 27 jobs passed

❌ ci:test:relevant - 105 out of 109 jobs passed in 4 hours 59 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d365f9baded97fa9119cb07f5e0342304bf6c298

Upstream Comparison:

Branch GIT ID: d365f9baded97fa9119cb07f5e0342304bf6c298
Jenkins Build URL: Acceptance Upstream DXP (master) #3545

ci:test:stable - 27 out of 27 jobs PASSED
27 Successful Jobs:
ci:test:relevant - 105 out of 109 jobs PASSED
105 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. functional-tomcat90-mysql57-jdk8/1/13
    [beanshell] Created S3 Object https://storage.cloud.google.com/testray-results/2022-07/test-1-30/test-portal-acceptance-pullrequest(master)/3822/functional-tomcat90-mysql57-jdk8/1/13/LocalFile.DMFileEntry_CanCheckInAsCurrentVersion/summary.html.gz in 188 ms
[beanshell] Created S3 Object https://storage.cloud.google.com/testray-results/2022-07/test-1-30/test-portal-acceptance-pullrequest(master)/3822/functional-tomcat90-mysql57-jdk8/1/13/LocalFile.DMFileEntry_CanDeleteMultipleDocumentsViaActionsButton/index.html.gz in 221 ms
[beanshell] Created S3 Object https://storage.cloud.google.com/testray-results/2022-07/test-1-30/test-portal-acceptance-pullrequest(master)/3822/functional-tomcat90-mysql57-jdk8/1/13/LocalFile.DMFileEntry_CanDeleteMultipleDocumentsViaActionsButton/summary.html.gz in 221 ms
[beanshell] Created S3 Object https://storage.cloud.google.com/testray-results/2022-07/test-1-30/test-portal-acceptance-pullrequest(master)/3822/functional-tomcat90-mysql57-jdk8/1/13/LocalFile.DMFileEntry_CanCheckInAsMinorVersion/index.html.gz in 223 ms
[beanshell] Created S3 Object https://storage.cloud.google.com/testray-results/2022-07/test-1-30/test-portal-acceptance-pullrequest(master)/3822/functional-tomcat90-mysql57-jdk8/1/13/LocalFile.DMFileEntry_CanCheckInAsMinorVersion/summary.html.gz in 211 ms
[beanshell] Created S3 Object https://storage.cloud.google.com/testray-results/2022-07/test-1-30/test-portal-acceptance-pullrequest(master)/3822/functional-tomcat90-mysql57-jdk8/1/13/jenkins-console.txt.gz in 237 ms
[stopwatch] [run.current.job: 38:55.112 sec]
[beanshell] Created cache file in /tmp/jenkins-cached-files/-1909478202.txt

    BUILD FAILED
    
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:14749: The following error occurred while executing this line:
    
/opt/dev/projects/github/liferay-portal/build-test-batch.xml:4673: The following error occurred while executing this line:
    
/opt/dev/projects/github/liferay-portal/build-test-batch.xml:1652: Task [run-batch-test] failed after [0] attempts; giving up.
    
Error messages:
    
The following error occurred while executing this line:
    
/opt/dev/projects/github/liferay-portal/build-test-batch.xml:1406: The following error occurred while executing this line:
    
/opt/dev/projects/github/liferay-portal/build-test-batch.xml:47: /opt/dev/projects/github/liferay-portal/20220714113358677.txt doesn't exist
Failures in common with acceptance upstream results at d365f9b:
  1. central-requirements-jdk8/0/0
    1. com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles
      junit.framework.AssertionFailedError: Incorrect configuration of dependency {compileOnly group: "com.liferay.portal", name: "com.liferay.portal.kernel", version: "default"} in modules/apps/cookies/cookies-test/build.gradle, use one of these instead: "testCompile", "testIntegrationCompile", "testIntegrationRuntime", "testRuntime"
      
at com.liferay.portal.modules.ModulesStructureTest._testGradleFile(ModulesStructureTest.java:1506)
      
at com.liferay.portal.modules.ModulesStructureTest.access$800(ModulesStructureTest.java:68)
      
at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:402)
      
at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:376)
      
at java.nio.file.Files.walkFileTree(Files.java:2670)
      
at java.nio.file.Files.walkFileTree(Files.java:2742)
      
at com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles(ModulesStructureTest.java:374)

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 25 out of 26 jobs passed

✔️ ci:test:relevant - 104 out of 107 jobs passed in 4 hours 55 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d365f9baded97fa9119cb07f5e0342304bf6c298

Upstream Comparison:

Branch GIT ID: d365f9baded97fa9119cb07f5e0342304bf6c298
Jenkins Build URL: Acceptance Upstream DXP (master) #3545

ci:test:stable - 25 out of 26 jobs PASSED

1 Failed Jobs:

25 Successful Jobs:
ci:test:relevant - 103 out of 107 jobs PASSED

4 Failed Jobs:

103 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at d365f9b:
  1. central-requirements-jdk8/0/0
    1. com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles
      junit.framework.AssertionFailedError: Incorrect configuration of dependency \{compileOnly group: "com.liferay.portal", name: "com.liferay.portal.kernel", version: "default"\} in modules/apps/cookies/cookies-test/build.gradle, use one of these instead: "testCompile", "testIntegrationCompile", "testIntegrationRuntime", "testRuntime"
  at com.liferay.portal.modules.ModulesStructureTest._testGradleFile(ModulesStructureTest.java:1506)
  at com.liferay.portal.modules.ModulesStructureTest.access\$800(ModulesStructureTest.java:68)
  at com.liferay.portal.modules.ModulesStructureTest\$4.visitFile(ModulesStructureTest.java:402)
  at com.liferay.portal.modules.ModulesStructureTest\$4.visitFile(ModulesStructureTest.java:376)
  at java.nio.file.Files.walkFileTree(Files.java:2670)
  at java.nio.file.Files.walkFileTree(Files.java:2742)
  at com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles(ModulesStructureTest.java:374)
  3. modules-integration-mysql57-jdk8_stable/0/1
    1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
      junit.framework.AssertionFailedError: 
Unable to extend the HTTP session. Review the portal property "session.timeout" if this warning is displayed frequently.
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest\$1.visitFile(PortalLogAssertorTest.java:98)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest\$1.visitFile(PortalLogAssertorTest.java:88)
  at java.nio.file.Files.walkFileTree(Files.java:2670)
  at java.nio.file.Files.walkFileTree(Files.java:2742)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

@liferay-continuous-integration
Copy link
Collaborator

@AliciaGarciaGarcia
Copy link
Collaborator

see #3256 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliciaGarciaGarcia AliciaGarciaGarcia AliciaGarciaGarcia approved these changes

Assignees
No one assigned
Labels
🔍 backend review needed ci:test:relevant - failure ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
5 participants
@adolfopa @liferay-content-management @liferay-continuous-integration @AliciaGarciaGarcia @brianchandotcom