New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-159330 Adds an InfoItemPermissionProvider implementation to handle ObjectEntry permission checks #853
Conversation
…tEntry identifier without having to get the ObjectEntry
CI is automatically triggering the following test suites:
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-159330_ObjectEntryInfoItemPermissionProvider 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#1884 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-objects#853 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#6078 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
ci:forward |
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
Skipping previously passed test suites: |
❌ ci:test:stable - 25 out of 26 jobs passed❌ ci:test:relevant - 75 out of 83 jobs passed in 1 hour 29 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: c123a8a2c1fe12c495f67fc84c19285102cf206e ci:test:stable - 25 out of 26 jobs PASSED1 Failed Jobs:
25 Successful Jobs:
ci:test:relevant - 75 out of 83 jobs PASSED8 Failed Jobs:
75 Successful Jobs:
For more details click here.Failures unique to this pull:
Failures in common with acceptance upstream results at c123a8a:
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#2494 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-objects#853 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - lfbesada > liferay-objects - PR#853 - 2022-08-05[06:58:07] Testray Importer:publish-testray-report#6388 |
ci:forward |
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
Skipping previously passed test suites: |
❌ ci:test:stable - 25 out of 26 jobs passed❌ ci:test:relevant - 75 out of 83 jobs passed in 2 hours 10 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: c123a8a2c1fe12c495f67fc84c19285102cf206e ci:test:stable - 25 out of 26 jobs PASSED1 Failed Jobs:
25 Successful Jobs:
ci:test:relevant - 75 out of 83 jobs PASSED8 Failed Jobs:
75 Successful Jobs:
For more details click here.Failures unique to this pull:
Failures in common with acceptance upstream results at c123a8a:
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#2497 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-objects#853 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - lfbesada > liferay-objects - PR#853 - 2022-08-05[09:01:56] Testray Importer:publish-testray-report#6392 |
ci:test:relevant |
✔️ ci:test:stable - 26 out of 26 jobs passed❌ ci:test:relevant - 75 out of 83 jobs passed in 1 hour 25 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: f8c8471ef2238e38442ddcd644556e852343ded4 ci:test:stable - 26 out of 26 jobs PASSED26 Successful Jobs:
ci:test:relevant - 75 out of 83 jobs PASSED8 Failed Jobs:
75 Successful Jobs:
For more details click here.Failures unique to this pull:Failures in common with acceptance upstream results at f8c8471:
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#5132 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-objects#853 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - lfbesada > liferay-objects - PR#853 - 2022-08-05[13:27:20] Testray Importer:publish-testray-report#13882 |
ci:forward |
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
Skipping previously passed test suites: |
✔️ ci:test:stable - 26 out of 26 jobs passed✔️ ci:test:relevant - 78 out of 83 jobs passed in 2 hours 60 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 2a5cbbe1617601b23bae9337c9dac6ddd6111124 ci:test:stable - 26 out of 26 jobs PASSED26 Successful Jobs:
ci:test:relevant - 77 out of 83 jobs PASSED6 Failed Jobs:
77 Successful Jobs:
For more details click here.This pull contains no unique failures.Failures in common with acceptance upstream results at 2a5cbbe:
|
All required test suite(s) passed. |
Pull request has been successfully forwarded to brianchandotcom#121395 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#2830 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-objects#853 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - lfbesada > liferay-objects - PR#853 - 2022-08-08[07:10:27] Testray Importer:publish-testray-report#6482 |
https://issues.liferay.com/browse/LPS-159330
Hi Team,
Could you please review it?
Thanks!
Regards