LPS-153687 Add fetchSharingCollaborators to the Info display Context #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
cgoncas
force-pushed
the
LPS-153687.Backend
branch
from
c49e363
to
fd0a7e5
Compare
…rdAdminSharingDisplayContext.
cgoncas
force-pushed
the
LPS-153687.Backend
branch
from
fd0a7e5
to
737de8d
Compare
|
ci:test:sf |
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - failure
and removed
ci:test:sf - pending
labels
❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-153687.Backend 1 Failed Jobs:For more details click here. [java] java.lang.Exception: Found 2 formatting issues:
[java] 1: No need to declare variable 'liferayPortletResponse'. Pass the method call directly as parameter on line '83'.: ./modules/apps/content-dashboard/content-dashboard-blogs-impl/src/main/java/com/liferay/content/dashboard/blogs/internal/item/action/SharingCollaboratorsBlogsEntryContentDashboardItemAction.java 79 (Checkstyle:VariableDeclarationAsUsedCheck)
[java] 2: No need to call 'portletURL.toString', use 'buildString' instead of 'buildPortletURL', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/check/builder_check.markdown: ./modules/apps/content-dashboard/content-dashboard-blogs-impl/src/main/java/com/liferay/content/dashboard/blogs/internal/item/action/SharingCollaboratorsBlogsEntryContentDashboardItemAction.java 96 (Checkstyle:PortletURLBuilderCheck)
[java]
[java] at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:442)
[java] at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:284)
[stopwatch] [run.batch.test.action: 58.550 sec]
[echo] The following error occurred while executing this line:
[echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:450: The following error occurred while executing this line:
[echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:593: Java returned: 1
[get] Getting: http://test-1-35/job/test-portal-source-format/1339//consoleText
[get] To: /opt/dev/projects/github/liferay-portal/20220726100108295.txt
[delete] Deleting: /opt/dev/projects/github/liferay-portal/20220726100108295.txt
[typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
[taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
[delete] Deleting: /opt/dev/projects/github/liferay-portal/null672549779.properties
|
…s taglib if if is visible.
|
Jenkins Build:test-portal-source-format#1339 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-tango#2636 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#5202 |
cgoncas
force-pushed
the
LPS-153687.Backend
branch
from
737de8d
to
9b1a10b
Compare
|
ci:test:relevant |
|
ci:test:sf |
❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-153687.Backend 1 Failed Jobs:For more details click here. [java] java.lang.Exception: Found 6 formatting issues:
[java] 1: No need to declare variable 'liferayPortletResponse'. Pass the method call directly as parameter on line '83'.: ./modules/apps/content-dashboard/content-dashboard-blogs-impl/src/main/java/com/liferay/content/dashboard/blogs/internal/item/action/SharingCollaboratorsBlogsEntryContentDashboardItemAction.java 79 (Checkstyle:VariableDeclarationAsUsedCheck)
[java] 2: No need to call 'portletURL.toString', use 'buildString' instead of 'buildPortletURL', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/check/builder_check.markdown: ./modules/apps/content-dashboard/content-dashboard-blogs-impl/src/main/java/com/liferay/content/dashboard/blogs/internal/item/action/SharingCollaboratorsBlogsEntryContentDashboardItemAction.java 96 (Checkstyle:PortletURLBuilderCheck)
[java] 3: No need to declare variable 'liferayPortletResponse'. Pass the method call directly as parameter on line '83'.: ./modules/apps/content-dashboard/content-dashboard-document-library-impl/src/main/java/com/liferay/content/dashboard/document/library/internal/item/action/SharingCollaboratorsFileEntryContentDashboardItemAction.java 79 (Checkstyle:VariableDeclarationAsUsedCheck)
[java] 4: No need to call 'portletURL.toString', use 'buildString' instead of 'buildPortletURL', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/check/builder_check.markdown: ./modules/apps/content-dashboard/content-dashboard-document-library-impl/src/main/java/com/liferay/content/dashboard/document/library/internal/item/action/SharingCollaboratorsFileEntryContentDashboardItemAction.java 96 (Checkstyle:PortletURLBuilderCheck)
[java] 5: ./modules/apps/content-dashboard/content-dashboard-document-library-impl/src/main/java/com/liferay/content/dashboard/document/library/internal/item/action/provider/SharingCollaboratorsFileEntryContentDashboardItemActionProvider.java expected:<...ry.getFileEntryId(),[
[java] themeDisplay.getScopeGroupId())) \{
[java]
[java] return true;
[java] \}
[java] \}
[java] catch (PortalException portalException) \{
[java] _log.error(portalException);
[java]
[java] return false;
[java] \}
[java]
[java] return false;
[java] \}
[java] |
|
Jenkins Build:test-portal-source-format#2893 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-tango#2636 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#10588 |
cgoncas
force-pushed
the
LPS-153687.Backend
branch
from
976f7bd
to
e9e0e37
Compare
|
ci:test:sf |
|
ci:test:relevant |
liferay-continuous-integration
added
ci:test:sf - pending
and removed
ci:test:sf - failure
ci:test:sf - pending
labels
✔️ ci:test:stable - 27 out of 27 jobs passed❌ ci:test:relevant - 46 out of 49 jobs passed in 1 hour 18 minutesClick here for more details.This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result: ci:reevaluate:1317401_4366 Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: e9a5492319dcfab370b8c5ae5cf26b79237f8531 ci:test:stable - 27 out of 27 jobs PASSED27 Successful Jobs:
ci:test:relevant - 46 out of 49 jobs PASSED3 Failed Jobs:
46 Successful Jobs:
For more details click here.Failures unique to this pull:
Failures in common with acceptance upstream results at e9a5492:
|
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
liferay-continuous-integration
added
ci:test:sf - pending
and removed
ci:test:sf - success
labels
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#4366 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-tango#2636 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - liferay-tango > liferay-tango - PR#2636 - 2022-07-26[21:59:40] Testray Importer:publish-testray-report#11732 |
liferay-continuous-integration
added
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-153687.Backend 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#1841 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-tango#2636 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#5923 |
| @@ -142,6 +142,10 @@ protected void doServeResource( | |||
| "fetchSharingButtonURL", | |||
| _getFetchSharingButtonURL( | |||
| contentDashboardItem, httpServletRequest) | |||
| ).put( | |||
| "fetchSharingContactsURL", | |||
There was a problem hiding this comment.
fetchSharingCollaboratorsURL should be the right one :), could you fix it :)
✔️ ci:test:stable - 27 out of 27 jobs passed✔️ ci:test:relevant - 48 out of 49 jobs passed in 1 hour 25 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: e9a5492319dcfab370b8c5ae5cf26b79237f8531 ci:test:stable - 27 out of 27 jobs PASSED27 Successful Jobs:
ci:test:relevant - 47 out of 49 jobs PASSED2 Failed Jobs:
47 Successful Jobs:
For more details click here.This pull contains no unique failures.Failures in common with acceptance upstream results at e9a5492:
|
|
All required test suite(s) passed. |
|
Pull request has been successfully forwarded to brianchandotcom#120921 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#2580 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-tango#2636 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - liferay-tango > liferay-tango - PR#2636 - 2022-07-26[23:43:16] Testray Importer:publish-testray-report#5930 |
| "com_liferay_content_dashboard_web_portlet_" + | ||
| "ContentDashboardAdminPortlet" | ||
| ).setMVCPath( | ||
| "/sharing_collaborators_button.jsp" |
There was a problem hiding this comment.
@cgoncas maybe we missed to rename this path to "/sharing_collaborators.jsp"
i'm getting an error I did not realized before:
javax.portlet.PortletException: Path /sharing_collaborators_button.jsp is not accessible by portlet com_liferay_content_dashboard_web_portlet_ContentDashboardAdminPortlet
thxs!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As a content marketer, I want to see all my collaborators after sharing an asset, so that I can easily view and manage my collaborators on a specific asset.
Proposed Solution
This solution use the same approach described in #2612.
We have created a sharing_collaborators.jsp that includes the sharing:collaborators taglib, so the sharing collaborators is rendered using a fetch, as we do with the content performance panel.
Also in this PR we have include the new actions for Blogs and FileEntries that create a URL to this new JSP.
How to test it
Until the frontend part is send, no functional tests can be executed.
Integration tests will be sent in another PR.