Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React UI Edit Link should move cursor after link creation #128

Closed
jbalsas opened this issue Mar 12, 2015 · 3 comments
Closed

React UI Edit Link should move cursor after link creation #128

jbalsas opened this issue Mar 12, 2015 · 3 comments
Labels
Milestone

Comments

@jbalsas
Copy link
Member

@jbalsas jbalsas commented Mar 12, 2015

In the ReactUI, after creating a link, the selection is retained and the link button shows. It would be better if the selection was moved after the created/updated link so the user can keep writing.

@ipeychev ipeychev added the feature label Mar 17, 2015
@jbalsas
Copy link
Member Author

@jbalsas jbalsas commented Dec 12, 2015

Hey @ipeychev,

Now that we've changed the link selection, it could make sense to rethink this. This is the current state:

  • After creating a new link, we change the selection to get all the element. This now causes the text selection buttons to show in the styles toolbar. (this looks good to me)
  • After updating an existing link, we keep the empty selection, so the edit link UI doesn't go away.

The way I see it, we could either select the link on update to match the create behaviour, or advance the cursor to the next position after the link as suggested in #387 on both cases to always dismiss the styles toolbar after a link has been edited.

What do you think?

@ipeychev
Copy link
Contributor

@ipeychev ipeychev commented Dec 13, 2015

Hey Chema,

I would expect the toolbar to disappear in both cases. After all, the primary operation - creation/editing the link has been completed. After creation, it is quite unusual to modify the style, so despite it is convenient that the toolbar stays there, I feel that most of the users won't touch it, so probably this will only force them to click one more time.
On editing, is the same logic. The goal - link editing has been completed, so I would expect the toolbar to disappear.

Thanks,

@jbalsas
Copy link
Member Author

@jbalsas jbalsas commented Dec 13, 2015

Hey Iliyan,

Makes sense, it's also aligned with what was being asked in #387.

Will work on that direction then 😊

@jbalsas jbalsas closed this in ee44eb0 Dec 19, 2015
ipeychev added a commit that referenced this issue Dec 19, 2015
Fixes #128
@ipeychev ipeychev added this to the 0.7.1 milestone Dec 19, 2015
ipeychev added a commit that referenced this issue Jan 2, 2016
Changing from key down to key up causes the following error:
if navigating with the keyboard on toolbar styles, pressing Enter on
button link causes rendering function of the toolbar to be
called twice. After the second call, the toolbar renders with
the default buttons instead with button-link-edit due to renderExclusive
flag set to false.

Fixes #128
ipeychev added a commit that referenced this issue Jan 2, 2016
Fixes #128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants