You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that we've changed the link selection, it could make sense to rethink this. This is the current state:
After creating a new link, we change the selection to get all the element. This now causes the text selection buttons to show in the styles toolbar. (this looks good to me)
After updating an existing link, we keep the empty selection, so the edit link UI doesn't go away.
The way I see it, we could either select the link on update to match the create behaviour, or advance the cursor to the next position after the link as suggested in #387 on both cases to always dismiss the styles toolbar after a link has been edited.
I would expect the toolbar to disappear in both cases. After all, the primary operation - creation/editing the link has been completed. After creation, it is quite unusual to modify the style, so despite it is convenient that the toolbar stays there, I feel that most of the users won't touch it, so probably this will only force them to click one more time.
On editing, is the same logic. The goal - link editing has been completed, so I would expect the toolbar to disappear.
Changing from key down to key up causes the following error:
if navigating with the keyboard on toolbar styles, pressing Enter on
button link causes rendering function of the toolbar to be
called twice. After the second call, the toolbar renders with
the default buttons instead with button-link-edit due to renderExclusive
flag set to false.