-
Notifications
You must be signed in to change notification settings - Fork 282
React UI Edit Link should move cursor after link creation #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey @ipeychev, Now that we've changed the link selection, it could make sense to rethink this. This is the current state:
The way I see it, we could either select the link on update to match the create behaviour, or advance the cursor to the next position after the link as suggested in #387 on both cases to always dismiss the styles toolbar after a link has been edited. What do you think? |
Hey Chema, I would expect the toolbar to disappear in both cases. After all, the primary operation - creation/editing the link has been completed. After creation, it is quite unusual to modify the style, so despite it is convenient that the toolbar stays there, I feel that most of the users won't touch it, so probably this will only force them to click one more time. Thanks, |
Hey Iliyan, Makes sense, it's also aligned with what was being asked in #387. Will work on that direction then 😊 |
Changing from key down to key up causes the following error: if navigating with the keyboard on toolbar styles, pressing Enter on button link causes rendering function of the toolbar to be called twice. After the second call, the toolbar renders with the default buttons instead with button-link-edit due to renderExclusive flag set to false. Fixes #128
In the ReactUI, after creating a link, the selection is retained and the link button shows. It would be better if the selection was moved after the created/updated link so the user can keep writing.
The text was updated successfully, but these errors were encountered: