Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement embedding YouTube videos #233

Closed
ipeychev opened this issue Jun 2, 2015 · 8 comments
Closed

Implement embedding YouTube videos #233

ipeychev opened this issue Jun 2, 2015 · 8 comments
Milestone

Comments

@ipeychev
Copy link
Contributor

@ipeychev ipeychev commented Jun 2, 2015

We need to embed YouTube videos on pasting an YouTube URL in the editor

@ipeychev ipeychev added this to the 0.3.2 milestone Jun 2, 2015
@ipeychev ipeychev modified the milestones: 0.3.3, 0.3.2 Jun 13, 2015
@ipeychev ipeychev modified the milestones: 0.3.3, 0.3.5, 0.3.6 Jun 24, 2015
@ghost
Copy link

@ghost ghost commented Sep 14, 2015

👍

@ColtonProvias
Copy link

@ColtonProvias ColtonProvias commented Sep 22, 2015

How about implementing oEmbed? Covers YouTube, Vimeo, SoundCloud, Flickr, etc.

@ipeychev
Copy link
Contributor Author

@ipeychev ipeychev commented Sep 22, 2015

Yes, that is what we were thinking to do.

@rothanachoun
Copy link

@rothanachoun rothanachoun commented Nov 28, 2015

+1

1 similar comment
@sanvuthy
Copy link

@sanvuthy sanvuthy commented Nov 30, 2015

👍

@jbalsas
Copy link
Member

@jbalsas jbalsas commented Nov 30, 2015

This can already be done using CKEditor's embed plugins. We'll try to do a simpler implementation that does not need all the dependencies, but in the meantime anyone can download and enable those.

@beeant
Copy link

@beeant beeant commented Dec 24, 2015

+1

@jbalsas jbalsas added this to the 1.0.0 milestone Jan 5, 2016
ipeychev added a commit that referenced this issue Feb 7, 2016
Fixes #233
@ipeychev ipeychev closed this in 3074a76 Feb 18, 2016
ipeychev added a commit that referenced this issue Feb 18, 2016
ipeychev added a commit that referenced this issue Feb 18, 2016
ipeychev added a commit that referenced this issue Feb 18, 2016
ipeychev added a commit that referenced this issue Feb 18, 2016
ipeychev added a commit that referenced this issue Feb 18, 2016
ipeychev added a commit that referenced this issue Feb 18, 2016
Fixes #233
@ipeychev
Copy link
Contributor Author

@ipeychev ipeychev commented Feb 27, 2016

See also #234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants