Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement embedding YouTube videos #233

Closed
ipeychev opened this issue Jun 2, 2015 · 8 comments
Closed

Implement embedding YouTube videos #233

ipeychev opened this issue Jun 2, 2015 · 8 comments
Labels
feature request
Milestone
1.0.0

Comments

@ipeychev
Copy link
Contributor

ipeychev commented Jun 2, 2015

We need to embed YouTube videos on pasting an YouTube URL in the editor
@ipeychev ipeychev added this to the 0.3.2 milestone Jun 2, 2015
@ipeychev ipeychev modified the milestones: 0.3.3, 0.3.2 Jun 13, 2015
@ipeychev ipeychev modified the milestones: 0.3.3, 0.3.5, 0.3.6 Jun 24, 2015
@ghost
Copy link

ghost commented Sep 14, 2015

👍

@ColtonProvias
Copy link

How about implementing oEmbed? Covers YouTube, Vimeo, SoundCloud, Flickr, etc.

@ipeychev
Copy link
Contributor Author

Yes, that is what we were thinking to do.

@rothanachoun
Copy link

+1

1 similar comment
@sanvuthy
Copy link

👍

@jbalsas
Copy link
Contributor

jbalsas commented Nov 30, 2015

This can already be done using CKEditor's embed plugins. We'll try to do a simpler implementation that does not need all the dependencies, but in the meantime anyone can download and enable those.

@sanvuthy sanvuthy mentioned this issue Dec 11, 2015
Closed
@beeant
Copy link

beeant commented Dec 24, 2015

+1

@jbalsas jbalsas mentioned this issue Jan 5, 2016
Merged
@jbalsas jbalsas added this to the 1.0.0 milestone Jan 5, 2016
ipeychev added a commit that referenced this issue Feb 7, 2016
@ipeychev
Add support for embedding media
894f053 
Fixes #233
ipeychev pushed a commit that referenced this issue Feb 18, 2016
@jbalsas @ipeychev
Add jsonp tool
5a9a3ec 
Fixes #233
ipeychev pushed a commit that referenced this issue Feb 18, 2016
@jbalsas @ipeychev
Add embed plugin to manage embed objects
0544f79 
Fixes #233
ipeychev pushed a commit that referenced this issue Feb 18, 2016
@jbalsas @ipeychev
Create Embed buttons to trigger the embed functionality
6fc3959 
Fixes #233
ipeychev pushed a commit that referenced this issue Feb 18, 2016
@jbalsas @ipeychev
Add embed selection
8026de6 
Fixes #233
ipeychev added a commit that referenced this issue Feb 18, 2016
@ipeychev
Convert widgets on paste
0197acf 
Fixes #233
ipeychev added a commit that referenced this issue Feb 18, 2016
@ipeychev
Source formatting
3500ca5 
Fixes #233
ipeychev added a commit that referenced this issue Feb 18, 2016
@ipeychev
Add build files (auto-generated)
d316752 
Fixes #233
@ipeychev
Copy link
Contributor Author

See also #234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
6 participants
@ipeychev @beeant @ColtonProvias @jbalsas @sanvuthy @rothanachoun