Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 0.14 #365

Closed
dantman opened this issue Nov 2, 2015 · 6 comments
Closed

React 0.14 #365

dantman opened this issue Nov 2, 2015 · 6 comments
Milestone

Comments

@dantman
Copy link
Contributor

@dantman dantman commented Nov 2, 2015

react@^0.14 has been released. It would be nice to consider switching to it in the next major release. Right now when alloy-editor is used in a page that uses React 0.14, AlloyEditor makes react emit deprecation notices for things that'll break in the following release.

@ipeychev ipeychev added this to the 0.6.1 milestone Nov 2, 2015
@ipeychev
Copy link
Contributor

@ipeychev ipeychev commented Nov 2, 2015

Yeah, thanks for the heads up, we will migrate it

@jbalsas
Copy link
Member

@jbalsas jbalsas commented Nov 2, 2015

Hey @dantman, that's definitely on our todo list. We'll try to get to it asap.

However, I think both @ipeychev and myself are quite swamped right now, so we will gladly review any contribution regarding this if it comes before we can tackle it :)

@ipeychev, based on the underlying changes in React, should we schedule the update for a 0.7 release instead of 0.6.1?

@ipeychev
Copy link
Contributor

@ipeychev ipeychev commented Nov 2, 2015

Yeah, depending on how much changes we have to do, it could be 0.7 too

@nickbouton
Copy link

@nickbouton nickbouton commented Nov 4, 2015

+1 for React 0.14 integration.

@jbalsas
Copy link
Member

@jbalsas jbalsas commented Nov 4, 2015

On its way! #370 😉

@jbalsas jbalsas closed this in 6f45b9b Nov 5, 2015
jbalsas added a commit that referenced this issue Nov 5, 2015
jbalsas added a commit that referenced this issue Nov 5, 2015
ipeychev added a commit that referenced this issue Nov 5, 2015
ipeychev added a commit that referenced this issue Nov 5, 2015
ipeychev added a commit that referenced this issue Nov 5, 2015
Fixes #365
@nickbouton
Copy link

@nickbouton nickbouton commented Nov 5, 2015

@jbalsas thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants