Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not try to require React if there is require function defined #406

Closed
ipeychev opened this issue Dec 23, 2015 · 0 comments
Closed

Does not try to require React if there is require function defined #406

ipeychev opened this issue Dec 23, 2015 · 0 comments
Labels
Milestone

Comments

@ipeychev
Copy link
Contributor

@ipeychev ipeychev commented Dec 23, 2015

AlloyEditor currently tries to find React from the global space or from the bundled version, but it does not try to require React.
If we require it, this should fix #405 and #389

@ipeychev ipeychev added the bug label Dec 23, 2015
@ipeychev ipeychev added this to the 0.7.1 milestone Dec 23, 2015
@ipeychev ipeychev removed this from the 0.7.1 milestone Dec 23, 2015
@ipeychev ipeychev added this to the 0.7.2 milestone Dec 23, 2015
@ipeychev ipeychev closed this in 763a432 Dec 23, 2015
ipeychev added a commit that referenced this issue Dec 23, 2015
Fixes #406
Fixes #405
Fixes #389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant