You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like the default CKEditor has a shortcut for adding a link, but it appears to not be in Alloy, and I can't quite figure out how to add it. Any tips or insights? Thanks!
We currently don't support this. In general, AlloyEditor is able to work with the keyboard (and it is also screen reader friendly) - by pressing Alt+F10 the toolbar will be focused and then you will be able to navigate using they arrows. Going back and forth to the next Toolbar is done using Tab.
However, directly invoking specific commands is not supported and I think this will a good feature.
Hey @kushal, as @ipeychev pointed out, some keystrokes aren't currently available in AlloyEditor because they're added by some CKEditor plugins we're not using. I'm working on a fix for this, that will allow creating keystrokes for the buttons.
Keep in mind, though, that AlloyEditor works in a different way, so the keystrokes will only be available as long as the button holding the required functionality is available in a toolbar. This means you won't be able to create a link just by pressing Cmd + L if you haven't selected any text. For that, however, we enable ae_autolink by default which creates links automatically as you type.
Create an additional selection with the linkEdit button that would resolve true for the created bookmarks
If everything plays out and a selectionChange event is triggered when creating the bookmark, that should prompt the special toolbar with the edit button. You'd need to take care of registering/unregistering the commands so they don't clash, but that's a way I can see it working.
@ipeychev, what do you think? Would you like to have this behaviour out of the box?
Activity
ipeychev commentedon Dec 31, 2015
Hey @kushal,
We currently don't support this. In general, AlloyEditor is able to work with the keyboard (and it is also screen reader friendly) - by pressing
Alt+F10the toolbar will be focused and then you will be able to navigate using they arrows. Going back and forth to the next Toolbar is done usingTab.However, directly invoking specific commands is not supported and I think this will a good feature.
jbalsas commentedon Jan 2, 2016
Hey @kushal, as @ipeychev pointed out, some keystrokes aren't currently available in
AlloyEditorbecause they're added by someCKEditorplugins we're not using. I'm working on a fix for this, that will allow creating keystrokes for the buttons.Keep in mind, though, that
AlloyEditorworks in a different way, so the keystrokes will only be available as long as the button holding the required functionality is available in a toolbar. This means you won't be able to create a link just by pressingCmd + Lif you haven't selected any text. For that, however, we enableae_autolinkby default which creates links automatically as you type.Properly document the object property
Add build files (auto-generated)
kushal commentedon Jan 5, 2016
This works great, thanks!
Out of curiosity, is there even a hacky way to make cmd-L work when no text
is selected?
On Sat, Jan 2, 2016 at 11:03 PM Chema Balsas notifications@github.com
wrote:
jbalsas commentedon Jan 5, 2016
Hey @kushal, as @ipeychev would say, "we are developers, we can do anything" 😉
I think you could:
cmd-Ltrigger a command that would create a CKEditor bookmarklinkEditbutton that would resolvetruefor the created bookmarksIf everything plays out and a
selectionChangeevent is triggered when creating the bookmark, that should prompt the special toolbar with the edit button. You'd need to take care of registering/unregistering the commands so they don't clash, but that's a way I can see it working.@ipeychev, what do you think? Would you like to have this behaviour out of the box?
ipeychev commentedon Jan 5, 2016
I vote with +1, definitely!
jbalsas commentedon Jan 5, 2016
Will work on that, then 😉
ipeychev commentedon Jan 5, 2016
That proves you are a real developer :)
jbalsas commentedon Jan 13, 2016
Hey @kushal, we just implemented this in #422. Should be in for the next release 😉
kushal commentedon Jan 13, 2016
Very cool!
On Tue, Jan 12, 2016 at 9:53 PM Chema Balsas notifications@github.com
wrote: