Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Remove Embed Link from Editor #517

Closed
btknorr opened this issue May 12, 2016 · 8 comments

Comments

Projects
None yet
3 participants
@btknorr
Copy link

commented May 12, 2016

We are using the most basic form of AlloyEditor, no plugins or anything. Just using AlloyEditor.editable('myContentEditable'); like stated in the guide.

Everything works great until you add an embed link. Once it's there, it cannot be removed. How do you remove an embed link? If you select it, the embed link field pops up, and if you click the X, and then the checkmark, it still remains. If you select it and then hit the backspace key, the browser goes back in it's history to the previous web page. Very frustrating...please advise.

Thanks,

Brian

@btknorr

This comment has been minimized.

Copy link
Author

commented May 12, 2016

See for yourself using the AlloyEditor demo, just add an embed link and then try to remove it :)

http://alloyeditor.com/demo

@jbalsas jbalsas added this to the 1.5.1 milestone May 13, 2016

@jbalsas jbalsas added the bug label May 13, 2016

@jbalsas

This comment has been minimized.

Copy link
Member

commented May 13, 2016

Hey @btknorr, I just verified the issue. I think it only happens if the embed content has an iframe. We have some code that forces the widget selection so it triggers a selectionChange event which seems to be causing the inner iframe to be focused making it impossible to remove.

If you're building AlloyEditor yourself, you may try commenting this line and rebuilding the editor.

We'll work on this next week to come up with a complete solution.

Thanks for letting us know about it, and sorry for the inconvenience!

@jbalsas

This comment has been minimized.

Copy link
Member

commented May 13, 2016

On a related note, this fix in upstream CKEditor might be relevant: http://dev.ckeditor.com/ticket/14538

@ipeychev

This comment has been minimized.

Copy link
Contributor

commented May 13, 2016

Hey Chema,

I was going to release this weekend ver. 1.5.1 which includes the fix for #515 (great job from @antoniopol06 and you), but in this case let's postpone it for one week and include the fix for this issue too, okay?

Thanks,

@jbalsas

This comment has been minimized.

Copy link
Member

commented May 13, 2016

Hey Iliyan, yeah, I agree. We'll work on this next week.

BTW, I think we should be planning 1.2.1, we're currently at 1.2.0 😅

@ipeychev

This comment has been minimized.

Copy link
Contributor

commented May 14, 2016

Yeah, correct, 1.2.1 of course - too many projects and I started to get confused which one is on which version :D
Btw, talking about versioning, do you know Semantic release/Commitizen? They help people to have better change logs and better versioning. Maybe it will be good idea to think for adopting them.

Thanks,

antoniopol06 added a commit to antoniopol06/alloy-editor that referenced this issue May 17, 2016

antoniopol06 added a commit to antoniopol06/alloy-editor that referenced this issue May 17, 2016

antoniopol06 added a commit to antoniopol06/alloy-editor that referenced this issue May 17, 2016

antoniopol06 added a commit to antoniopol06/alloy-editor that referenced this issue May 17, 2016

antoniopol06 added a commit to antoniopol06/alloy-editor that referenced this issue May 17, 2016

@jbalsas

This comment has been minimized.

Copy link
Member

commented May 21, 2016

I just sent a fix proposal for this (#517), including:

  • Allows for easy removal of the widgets using the keyboard
  • Adds a remove button to the embed toolbar like the one when editing a link
@jbalsas

This comment has been minimized.

Copy link
Member

commented May 21, 2016

@ipeychev, regarding the versioning, it does definitely sound interesting... let me take a look once I find some time for it, and I think this could be a nice playground to experiment with those ideas.

Thanks!

@ipeychev ipeychev closed this in e465784 May 23, 2016

ipeychev added a commit that referenced this issue May 23, 2016

ipeychev added a commit that referenced this issue May 23, 2016

ipeychev added a commit that referenced this issue May 23, 2016

ipeychev added a commit that referenced this issue May 23, 2016

ipeychev added a commit that referenced this issue May 23, 2016

ipeychev added a commit that referenced this issue May 23, 2016

ipeychev added a commit that referenced this issue May 23, 2016

ipeychev added a commit that referenced this issue May 23, 2016

Only enable remove button when embed is selected. Refactor to follow …
…button-link-edit pattern for consistency.

Fixes #517

ipeychev added a commit that referenced this issue May 23, 2016

ipeychev added a commit that referenced this issue May 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.