New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit embedded link is broken - popup displays above wrong element #526

Closed
btknorr opened this Issue May 24, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@btknorr

btknorr commented May 24, 2016

  1. Goto http://alloyeditor.com/demo/ and scroll down some, then add an embedded link. After you add it, the edit popup immediately shows in the correct spot.

  2. Click somewhere to dismiss the edit popup.

  3. Now click back on the embedded element to edit it. The edit popup displays far up the screen, and you have to scroll all the way up to see it hovering above the wrong element.

@ipeychev ipeychev added the bug label May 24, 2016

@ipeychev

This comment has been minimized.

Contributor

ipeychev commented May 24, 2016

Thanks for the report!

I think the element is selected properly, but the toolbar is not positioned properly - scrollTop is not taken in consideration. Should be easy to fix, if it is this one.

Thanks,

@ipeychev ipeychev added this to the 1.2.2 milestone May 24, 2016

@btknorr

This comment has been minimized.

btknorr commented May 24, 2016

Yep you are right...this only happens when you have to scroll down to the content to be edited.

@ipeychev ipeychev closed this in b3a4e24 May 25, 2016

ipeychev added a commit that referenced this issue May 25, 2016

@ipeychev

This comment has been minimized.

Contributor

ipeychev commented May 25, 2016

Fixed in v1.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment