Skip to content

/ alloy-editor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beforeImageAdd event is needed, when a single image is uploaded by the image button #534

Closed
amoallim15 opened this issue Jun 4, 2016 · 3 comments
Closed

beforeImageAdd event is needed, when a single image is uploaded by the image button #534

amoallim15 opened this issue Jun 4, 2016 · 3 comments
Labels
feature
Milestone
1.2.3

Comments

@amoallim15
Copy link

@amoallim15 amoallim15 commented Jun 4, 2016

In the closed issue #518 you suggested adding 'beforeImageAdd' event to pre handle the multi-image drag-n-drop. Actually, this event is way helpful if we can subscribe to it with the image button as well at buttom-image.jsx, for some pre-check of the file e.g. its size.
@amoallim15 amoallim15 changed the title beforeImageAdd event is needed, when a single image uploaded by the image button beforeImageAdd event is needed, when a single image is uploaded by the image button Jun 4, 2016
@ipeychev ipeychev added the feature label Jun 4, 2016
@ipeychev ipeychev added this to the 1.2.3 milestone Jun 4, 2016
@ipeychev ipeychev closed this in 13781cf Jun 4, 2016
ipeychev added a commit that referenced this issue Jun 4, 2016
@ipeychev
Add build files (auto-generated)
Loading status checks…
1dd8344 
Fixes #534
@ipeychev
Copy link
Contributor

@ipeychev ipeychev commented Jun 4, 2016

Correct, fixed.

Thanks for the heads up!
ipeychev added a commit that referenced this issue Jun 4, 2016
@ipeychev
Document `beforeImageAdd` event in button-image
402fa99 
Fixes #534
ipeychev added a commit that referenced this issue Jun 4, 2016
@ipeychev
Add build files (auto-generated)
Loading status checks…
895cc03 
Fixes #534
@amoallim15
Copy link
Author

@amoallim15 amoallim15 commented Jun 4, 2016

Great!, I'm starting to like this, thanks a lot )
@ipeychev
Copy link
Contributor

@ipeychev ipeychev commented Jun 29, 2016

Fixed in v1.2.3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
1.2.3
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@ipeychev @amoallim15