Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autolinkAdd doesn't work on urls that contain - in the domain name #657

Closed
deadcyclo opened this issue Dec 21, 2016 · 2 comments
Closed

autolinkAdd doesn't work on urls that contain - in the domain name #657

deadcyclo opened this issue Dec 21, 2016 · 2 comments
Assignees
@ipeychev
Labels
bug
Milestone
1.3.1

Comments

@deadcyclo
Copy link

The autolinkAdd feature ignores urls that contain a - So for example https://alloyeditor.com would be recognized as an url while https://alloy-editor.com would not even though alloy-editor.com is a perfectly legal domain name. I have verified that this issue occurs also in your online demo.
@ipeychev ipeychev added the bug label Dec 21, 2016
@ipeychev
Copy link
Contributor

Thanks for the report, I'll take a look.

@ipeychev ipeychev self-assigned this Dec 21, 2016
antoniopol06 pushed a commit to antoniopol06/alloy-editor that referenced this issue Dec 21, 2016
Cover test typing urls with - character
e4ea833 
Fixes liferay#657
@ipeychev
Copy link
Contributor

Ah, thanks, @antoniopol06, will check the PR later today or tomorrow morning.

ipeychev added a commit that referenced this issue Dec 22, 2016
@ipeychev
Add build files (auto-generated)
ec9f936 
Fixes #657
@jbalsas jbalsas added this to the 1.3.1 milestone Dec 22, 2016
azotova pushed a commit to azotova/alloy-editor that referenced this issue Jan 7, 2017
@azotova
Update regext to accept - into URLs
3b87a93 
Fixes liferay#657
azotova pushed a commit to azotova/alloy-editor that referenced this issue Jan 7, 2017
@azotova
Cover test typing urls with - character
a034462 
Fixes liferay#657
azotova pushed a commit to azotova/alloy-editor that referenced this issue Jan 7, 2017
@ipeychev @azotova
Add build files (auto-generated)
2171db9 
Fixes liferay#657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ipeychev ipeychev

Labels
bug
Projects
None yet
Milestone
1.3.1
Development

No branches or pull requests
3 participants
@ipeychev @jbalsas @deadcyclo