Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autolinkAdd doesn't work on urls that contain - in the domain name #657

Closed
deadcyclo opened this issue Dec 21, 2016 · 2 comments
Closed

autolinkAdd doesn't work on urls that contain - in the domain name #657

deadcyclo opened this issue Dec 21, 2016 · 2 comments
Assignees
Labels
bug
Milestone

Comments

@deadcyclo
Copy link

@deadcyclo deadcyclo commented Dec 21, 2016

The autolinkAdd feature ignores urls that contain a - So for example https://alloyeditor.com would be recognized as an url while https://alloy-editor.com would not even though alloy-editor.com is a perfectly legal domain name. I have verified that this issue occurs also in your online demo.

@ipeychev ipeychev added the bug label Dec 21, 2016
@ipeychev
Copy link
Contributor

@ipeychev ipeychev commented Dec 21, 2016

Thanks for the report, I'll take a look.

@ipeychev ipeychev self-assigned this Dec 21, 2016
antoniopol06 added a commit to antoniopol06/alloy-editor that referenced this issue Dec 21, 2016
@ipeychev
Copy link
Contributor

@ipeychev ipeychev commented Dec 21, 2016

Ah, thanks, @antoniopol06, will check the PR later today or tomorrow morning.

@ipeychev ipeychev closed this in 19d7224 Dec 22, 2016
ipeychev added a commit that referenced this issue Dec 22, 2016
Fixes #657
@jbalsas jbalsas added this to the 1.3.1 milestone Dec 22, 2016
azotova added a commit to azotova/alloy-editor that referenced this issue Jan 7, 2017
azotova added a commit to azotova/alloy-editor that referenced this issue Jan 7, 2017
azotova added a commit to azotova/alloy-editor that referenced this issue Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants