Context follow ups #1084
Merged
Context follow ups #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In response to a question by @jbalsas here: liferay#1055 (comment) These don't really serve any valuable purpose; I just left them there in PR liferay#1055 to keep the changes minimal.
As of: liferay#1055 we don't need to explicitly pass the editor prop around any more. These three buttons got merged while that PR was being developed; now that it has been landed, we should update the buttons. Test plan: `npm run dev && npm run test && npm run start` then check in editor demo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-ups to comments posted on #1055:
propTypesdeclarations.