Set contenteditable=false on editor destroy() when enableContentEditable is true #356
Conversation
Hey @mattleff, Thank you for the contribution! This PR looks good, some note about the commit rules we have:
Thanks again for the contribution! Iliyan |
Just started reviewing :) |
Thank you, pull request merged! See changes here. |
ipeychev
added a commit
that referenced
this pull request
Oct 14, 2015
Okay, I added the needed tests, but please the next time send us PR with tests. If you don't know how to do them, feel free to ask for help. Thanks, |
@ipeychev Sorry I hadn't had a chance to work on unit tests! Do you have a page that explains how to run the unit tests? I have a couple more pulls I'd like to send and I can do the unit tests if I know how. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This complements the behavior on editor creation.