Skip to content

Set contenteditable=false on editor destroy() when enableContentEditable is true - #356

Closed
mattleff wants to merge 1 commit into
liferay:masterfrom
SimpleUpdates:destroy-contenteditable
Closed

mattleff wants to merge 1 commit into
liferay:masterfrom
SimpleUpdates:destroy-contenteditable

Conversation

@mattleff

Copy link
Copy Markdown
Contributor

This complements the behavior on editor creation.

@ipeychev

Copy link
Copy Markdown
Member

Hey @mattleff,

Thank you for the contribution! This PR looks good, some note about the commit rules we have:

  1. Each commit should be associated with an issue. We do that by adding Fixes #xxx in the commit message. In this case we can track any comments related to the issue, etc.
  2. The commits should have tests, except if technically impossible. We do have tests for destroying the editor, you may add another one which covers the change in your PR.

Thanks again for the contribution!

Iliyan

@ipeychev

Copy link
Copy Markdown
Member

Just started reviewing :)

:octocat: Sent from GH.

@ipeychev ipeychev added this to the 0.6 milestone Oct 14, 2015
@ipeychev

Copy link
Copy Markdown
Member

Thank you, pull request merged! See changes here.

:octocat: Sent from GH.

@ipeychev ipeychev closed this in 8858d57 Oct 14, 2015
ipeychev added a commit that referenced this pull request Oct 14, 2015
ipeychev added a commit that referenced this pull request Oct 14, 2015
ipeychev added a commit that referenced this pull request Oct 14, 2015
@ipeychev

Copy link
Copy Markdown
Member

Okay, I added the needed tests, but please the next time send us PR with tests. If you don't know how to do them, feel free to ask for help.

Thanks,

@mattleff

Copy link
Copy Markdown
Contributor Author

@ipeychev Sorry I hadn't had a chance to work on unit tests! Do you have a page that explains how to run the unit tests? I have a couple more pulls I'd like to send and I can do the unit tests if I know how.

@ipeychev

Copy link
Copy Markdown
Member

Hey @mattleff,

The tests we run simple with with gulp test. I have on my machine (Mac) installed VMs for all the supported IE versions. I used ievms to install them.

Hope that helps!

@mattleff
mattleff deleted the destroy-contenteditable branch October 14, 2015 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants