Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use focus event instead of contentDOM to make sure initialization always runs #373

Merged
merged 1 commit into from Nov 6, 2015

Conversation

Projects
None yet
2 participants
@jbalsas
Copy link
Member

commented Nov 5, 2015

Hey @ipeychev, this is the fix for #371.

I've been fighting to get a proper test for a while and I can't spend much more time on it. On one side, React.TestUtils can't simulate pure DOM events, so we have to use CKEditor jquery or add something else.

Also, for some reason, I was observing a weird initialization order when destroying and recreating an AlloyEditor instance, which prevented me from covering the use case where we destroy and recreate the editor.

@ipeychev

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2015

Just started reviewing :)

:octocat: Sent from GH.

@ipeychev ipeychev merged commit e2a8540 into liferay:master Nov 6, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@ipeychev ipeychev referenced this pull request Nov 6, 2015

Closed

toolbar does not disappear #371

@jbalsas jbalsas deleted the jbalsas:AE-371-toolbar_hidden branch Jan 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.