Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMERCE-1768 fixed cell width on shipments table #1438

Merged
merged 1 commit into from Sep 29, 2019

Conversation

fabio-d-m
Copy link
Contributor

This fix the ui side of the problem. Also, inactive warehouses should not be visible but that should be fixed by backenders

@ethanbustad
Copy link
Contributor

ci:test

@liferay-continuous-integration
Copy link
Member

Validation PASSED. Running batch tests.

Build Time: 21 minutes 35 seconds 825 ms

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: c6ce08e1be3a36ca00ae564cd9ed5ae4c90481a5

Task Summary:
  • subrepository-compile-jdk8 - ✔️
  • subrepository-semantic-versioning-jdk8 - ✔️
  • subrepository-pmd-jdk8 - ✔️
  • subrepository-source-format-jdk8 - ✔️
  • central-requirements-jdk8/subrepository-unit-jdk8 - ✔️
For full console, click here.

Test Results:

10 Tests Passed.
0 Tests Failed.

For all test results, click here.

@liferay-continuous-integration
Copy link
Member

❌ ci:test - 10 out of 13 jobs passed in 1 hour 7 minutes 5 seconds 846 ms

Click here for more details.

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: c6ce08e1be3a36ca00ae564cd9ed5ae4c90481a5

10 out of 13 jobs PASSED
10 Successful Jobs:
For more details click here.

Failures (upstream comparison is not available):

  1. test-subrepository-acceptance-pullrequest-batch(7.1.x)/subrepository-integration-mysql57-jdk8
    Job Results:

    1792 Tests Passed.
    34 Tests Failed.

    1. AXIS_VARIABLE=1,label_exp=!master #313
      1. CommercePriceEntryLocalServiceTest.testAddCommercePriceEntry1
        org.hibernate.exception.ConstraintViolationException: Could not execute JDBC batch update
        	at org.hibernate.exception.SQLStateConverter.convert(SQLStateConverter.java:96)
        	at org.hibernate.exception.JDBCExceptionHelper.convert(JDBCExceptionHelper.java:66)
        	at org.hibernate.jdbc.AbstractBatcher.executeBatch(AbstractBatcher.java:275)
        	at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:268)
        	at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:184)
        	at org.hibernate.event.def.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:321)
        	at com.liferay.portal.dao.orm.hibernate.event.NestableFlushEventListener.onFlush(NestableFlushEventListener.java:61)
        	at org.hibernate.impl.SessionImpl.flush(SessionImpl.java:1216)
        	at com.liferay.portal.spring.hibernate.PortletTransactionManager$TransactionStatusWrapper.reset(PortletTransactionManager.java:260)
        	at com.liferay.portal.spring.hibernate.PortletTransactionManager.commit(PortletTransactionManager.java:63)
        	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor._commit(DefaultTransactionExecutor.java:164)
        	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor._execute(DefaultTransactionExecutor.java:211)
        	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.execute(DefaultTransactionExecutor.java:94)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:110)
        	at com.liferay.portal.spring...
      2. CommercePriceEntryLocalServiceTest.testAddCommercePriceEntry2
        org.hibernate.exception.ConstraintViolationException: Could not execute JDBC batch update
        	at org.hibernate.exception.SQLStateConverter.convert(SQLStateConverter.java:96)
        	at org.hibernate.exception.JDBCExceptionHelper.convert(JDBCExceptionHelper.java:66)
        	at org.hibernate.jdbc.AbstractBatcher.executeBatch(AbstractBatcher.java:275)
        	at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:268)
        	at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:184)
        	at org.hibernate.event.def.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:321)
        	at com.liferay.portal.dao.orm.hibernate.event.NestableFlushEventListener.onFlush(NestableFlushEventListener.java:61)
        	at org.hibernate.impl.SessionImpl.flush(SessionImpl.java:1216)
        	at com.liferay.portal.spring.hibernate.PortletTransactionManager$TransactionStatusWrapper.reset(PortletTransactionManager.java:260)
        	at com.liferay.portal.spring.hibernate.PortletTransactionManager.commit(PortletTransactionManager.java:63)
        	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor._commit(DefaultTransactionExecutor.java:164)
        	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor._execute(DefaultTransactionExecutor.java:211)
        	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.execute(DefaultTransactionExecutor.java:94)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:110)
        	at com.liferay.portal.spring...
      3. CommercePriceEntryLocalServiceTest.testFetchCommercePriceEntry1
        org.hibernate.exception.ConstraintViolationException: Could not execute JDBC batch update
        	at org.hibernate.exception.SQLStateConverter.convert(SQLStateConverter.java:96)
        	at org.hibernate.exception.JDBCExceptionHelper.convert(JDBCExceptionHelper.java:66)
        	at org.hibernate.jdbc.AbstractBatcher.executeBatch(AbstractBatcher.java:275)
        	at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:268)
        	at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:184)
        	at org.hibernate.event.def.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:321)
        	at com.liferay.portal.dao.orm.hibernate.event.NestableFlushEventListener.onFlush(NestableFlushEventListener.java:61)
        	at org.hibernate.impl.SessionImpl.flush(SessionImpl.java:1216)
        	at com.liferay.portal.spring.hibernate.PortletTransactionManager$TransactionStatusWrapper.reset(PortletTransactionManager.java:260)
        	at com.liferay.portal.spring.hibernate.PortletTransactionManager.commit(PortletTransactionManager.java:63)
        	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor._commit(DefaultTransactionExecutor.java:164)
        	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor._execute(DefaultTransactionExecutor.java:211)
        	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.execute(DefaultTransactionExecutor.java:94)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:110)
        	at com.liferay.portal.spring...
      4. ...

@ethanbustad
Copy link
Contributor

ci:test
Tests may pass now that #1436 is merged in.

@liferay-continuous-integration
Copy link
Member

Validation PASSED. Running batch tests.

Build Time: 18 minutes 36 seconds 902 ms

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: 35d786d27bd94ebe0a6fea7507e486f3f91be58d

Task Summary:
  • subrepository-compile-jdk8 - ✔️
  • subrepository-semantic-versioning-jdk8 - ✔️
  • subrepository-pmd-jdk8 - ✔️
  • subrepository-source-format-jdk8 - ✔️
  • central-requirements-jdk8/subrepository-unit-jdk8 - ✔️
For full console, click here.

Test Results:

10 Tests Passed.
0 Tests Failed.

For all test results, click here.

@liferay-continuous-integration
Copy link
Member

❌ ci:test - 11 out of 13 jobs passed in 1 hour 3 minutes 29 seconds 710 ms

Click here for more details.

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: 35d786d27bd94ebe0a6fea7507e486f3f91be58d

11 out of 13 jobs PASSED
11 Successful Jobs:
For more details click here.

Failures (upstream comparison is not available):

  1. test-subrepository-acceptance-pullrequest-batch(7.1.x)/functional-smoke-tomcat90-mysql57-jdk8/0
    Job Results:

    2 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #484
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        com.liferay.portal.kernel.exception.PortalException: Impossible to load https://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml
        com.liferay.portal.kernel.exception.PortalException: Impossible to load https://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml
        	at com.liferay.commerce.currency.internal.util.ECBExchangeRateProvider.getExchangeRate(ECBExchangeRateProvider.java:83)
        	at com.liferay.commerce.currency.service.impl.CommerceCurrencyLocalServiceImpl.updateExchangeRate(CommerceCurrencyLocalServiceImpl.java:391)
        	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:153)
        	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor._execute(DefaultTransactionExecutor.java:203)
        	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.execute(DefaultTransactionExecutor.java:94)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:110)
        	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:130)
        	at com.liferay.portal.spring.aop.RetryAdvice.invoke(RetryAdvice.java:47)
        	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:130)
        	at com.liferay.portal.service.ServiceContextAdvice.invoke(ServiceContextAdvice.java:39)
        	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:130)...

@marco-leo marco-leo merged commit 000a7a3 into liferay:7.1.x-next Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants