bs3-bs4-compat: Add Lexicon 1.x mixins that were removed in Clay 2.x / 3.x

[pat270]

Issue type (mark with x)

• 🐛 Bug report

Version (mark with x)

• 🔟 v10.x or higher

Description

Some mixins are missing when upgrading 7.1 themes to 7.4. The bs3-bs4-compat layer should also include Lexicon 1.x mixins that were removed.

Desired behavior:

Current behavior:

Repro instructions (if applicable):

Other information (environment, versions etc):

[izaera]

Can you please specify how to upgrade from 7.1 to 7.4 and provide some steps we can follow to reproduce it?
IINM you need to use several Themes Toolkit versions? 🤔 I mean, I think you cannot do it with a single step, IIRC...

[pat270]

@izaera I'm going off this thread. I guess it's not really a 7.1 theme, but one that is currently going through the process of being upgraded. They're running into some issues that could be fixed in the compatibility layer.

Edit: Their theme is relying on some Lexicon 1.x mixins and variables which no longer exist in Clay 2/3.

[izaera]

Mmm, I see...

So, we have two bs3-bs4-compat projects in this repo:

1. https://github.com/liferay/liferay-frontend-projects/tree/master/projects/js-themes-toolkit/packages/bs3-bs4-compat
2. https://github.com/liferay/liferay-frontend-projects/tree/master/maintenance/projects/js-themes-toolkit-v10-x/packages/bs3-bs4-compat

One is for the current Themes Toolkit version (v11), the other one is for the v10 series.

• Which one should be changed? Or should both be changed?
• And what is exactly the change being requested (mind that I don't have any idea of what mixins you are referring to and I don't know the internal structure of Clay either)?
  • Is it just adding a new dep in one (or both) of those two project?
  • Or is it changing a version number?
  • ...

[pat270]

@izaera probably all of them. I'll send you a pr and you can take a look at it.

Edit: It's copying and pasting some mixins from Lexicon 1.x into bs3-bs4-compat.

[izaera]

A PR would be great 👍 Thx