From 63989c9d31f00113a208ae0b2b226dc5d261951b Mon Sep 17 00:00:00 2001 From: Greg Hurrell Date: Thu, 8 Oct 2020 10:54:13 +0200 Subject: [PATCH] chore(js-toolkit): configure release messages consistently - Adjust existing .yarnrc files so that the release commit message matches the format used by other packages in this monorepo. - Add .yarnrc files for packages that don't have them yet. - Configure Lerna (still used in v2 of the js-toolkit) to produce commit messages that match the format produced by yarn; previously they produced commit messages consisting just of the bare version number (eg. see b493e109afa2c706ce5fcea79b81a54ac72578d9), which isn't appropriate for a multi-project monorepo. --- maintenance/projects/js-toolkit/lerna.json | 3 +++ projects/js-toolkit/packages/generator-liferay-js/.yarnrc | 3 +++ projects/js-toolkit/packages/liferay-js-toolkit-core/.yarnrc | 2 +- .../js-toolkit/packages/liferay-js-toolkit-scripts/.yarnrc | 3 +++ .../js-toolkit/packages/liferay-npm-bridge-generator/.yarnrc | 3 +++ projects/js-toolkit/packages/liferay-npm-bundler/.yarnrc | 2 +- 6 files changed, 14 insertions(+), 2 deletions(-) create mode 100644 projects/js-toolkit/packages/generator-liferay-js/.yarnrc create mode 100644 projects/js-toolkit/packages/liferay-js-toolkit-scripts/.yarnrc create mode 100644 projects/js-toolkit/packages/liferay-npm-bridge-generator/.yarnrc diff --git a/maintenance/projects/js-toolkit/lerna.json b/maintenance/projects/js-toolkit/lerna.json index 827f75d8c0..f5aea8f315 100644 --- a/maintenance/projects/js-toolkit/lerna.json +++ b/maintenance/projects/js-toolkit/lerna.json @@ -3,6 +3,9 @@ "command": { "publish": { "exact": true + }, + "version": { + "message": "chore: prepare liferay-js-toolkit/%s release" } }, "npmClient": "yarn", diff --git a/projects/js-toolkit/packages/generator-liferay-js/.yarnrc b/projects/js-toolkit/packages/generator-liferay-js/.yarnrc new file mode 100644 index 0000000000..826745bb64 --- /dev/null +++ b/projects/js-toolkit/packages/generator-liferay-js/.yarnrc @@ -0,0 +1,3 @@ +# Make `yarn version` produce the right commit message and tag for this package. +version-tag-prefix "generator-liferay-js/v" +version-git-message "chore: prepare generator-liferay-js/v%s release" diff --git a/projects/js-toolkit/packages/liferay-js-toolkit-core/.yarnrc b/projects/js-toolkit/packages/liferay-js-toolkit-core/.yarnrc index adc05e73a5..773fdf8a63 100644 --- a/projects/js-toolkit/packages/liferay-js-toolkit-core/.yarnrc +++ b/projects/js-toolkit/packages/liferay-js-toolkit-core/.yarnrc @@ -1,3 +1,3 @@ # Make `yarn version` produce the right commit message and tag for this package. version-tag-prefix "liferay-js-toolkit-core/v" -version-git-message "chore: prepare liferay-js-toolkit-core/v%s" +version-git-message "chore: prepare liferay-js-toolkit-core/v%s release" diff --git a/projects/js-toolkit/packages/liferay-js-toolkit-scripts/.yarnrc b/projects/js-toolkit/packages/liferay-js-toolkit-scripts/.yarnrc new file mode 100644 index 0000000000..53189c264b --- /dev/null +++ b/projects/js-toolkit/packages/liferay-js-toolkit-scripts/.yarnrc @@ -0,0 +1,3 @@ +# Make `yarn version` produce the right commit message and tag for this package. +version-tag-prefix "liferay-js-toolkit-scripts/v" +version-git-message "chore: prepare liferay-js-toolkit-scripts/v%s release" diff --git a/projects/js-toolkit/packages/liferay-npm-bridge-generator/.yarnrc b/projects/js-toolkit/packages/liferay-npm-bridge-generator/.yarnrc new file mode 100644 index 0000000000..1e5b145805 --- /dev/null +++ b/projects/js-toolkit/packages/liferay-npm-bridge-generator/.yarnrc @@ -0,0 +1,3 @@ +# Make `yarn version` produce the right commit message and tag for this package. +version-tag-prefix "liferay-npm-bridge-generator/v" +version-git-message "chore: prepare liferay-npm-bridge-generator/v%s release" diff --git a/projects/js-toolkit/packages/liferay-npm-bundler/.yarnrc b/projects/js-toolkit/packages/liferay-npm-bundler/.yarnrc index 916fa970f6..000b7a1370 100644 --- a/projects/js-toolkit/packages/liferay-npm-bundler/.yarnrc +++ b/projects/js-toolkit/packages/liferay-npm-bundler/.yarnrc @@ -1,3 +1,3 @@ # Make `yarn version` produce the right commit message and tag for this package. version-tag-prefix "liferay-npm-bundler/v" -version-git-message "chore: prepare liferay-npm-bundler/v%s" +version-git-message "chore: prepare liferay-npm-bundler/v%s release"