feat: provide a mechanism to extend the remotes and shared fields of webpack config
#382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webpack 5 doesn't provide shims for built-in node packages, so we need to provide one for `path` ourselves given that `@clayui/css` uses it. We choose `path-browserify` because webpack itself suggests it. And we blindly believe and follow what webpack says.
…gmented This is necessary for project-specific imports and shared packages.
When an `export default ...` is placed in a file the build failed unless it was an `export default ... from ...`.
izaera
commented
Jan 13, 2021
| "metal-tools-soy": "4.3.2", | ||
| "mini-css-extract-plugin": "0.11.2", | ||
| "minimist": "^1.2.0", | ||
| "path-browserify": "^1.0.1", |
izaera
commented
Jan 13, 2021
| * This object must represent the current configuration status of the portal's | ||
| * project if we don't want to break the build. It contains, for each | ||
| * federation-enabled project, the packages that are federated. | ||
| * The following two arrays are roughly equivalent to the old default preset |
Member
Author
There was a problem hiding this comment.
Turns out that I was wrong in the previous PR and it didn't make too much sense to mix imports and federation because the model is a bit different.
izaera
commented
Jan 13, 2021
| dependencies: | ||
| execa "^1.0.0" | ||
|
|
||
| path-browserify@^1.0.1: |
Member
Author
There was a problem hiding this comment.
Mmmm, I love the smell of new dependencies in the morning....
🚁 🔥
Member
Author
|
As agreed with @jbalsas in a slack conversation I'm merging this to avoid blocking the server side PR. If we want to add changes later we can do it without any problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See IFI-2310.
The changes here are needed to build and deploy this branch.
I will release a new version of
npm-scriptsafter this is merged which, BTW, should be the last that we need unless we add new features or fix bugs, because I have added all information contained in the old default preset (see this commit) given that it doesn't fail the build. In addition, it has been made extensible, so..., that should be enough.As always this has been tested locally with the linked private branch of
liferay-portal.I will send the portal's PR as soon as we release a new version of npm-scripts.