fix: replaced address zero checks with fn invocation #50 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H3xept
changed the title
0xDEnYO
added a commit
that referenced
this pull request
Jun 19, 2024
0xDEnYO
added a commit
that referenced
this pull request
Jul 4, 2024
…iverStargateV2 v.1.0.0) (#678) * merged external changes * update deploy requirements * deploy logs reinstated * cleanup * stargate reviewer comments implemented * added a check to make sure taxi mode is used for dest calls (audit issue #14) * tests fixed * removed unused import (audit issue #10) * updated comment (audit issue #9) * updated test setup so that receive function in facet is not required (audit issue #6) * removed unnecessary parameter (reserveRecoverGas) in Receiver (audit issue #7) * use safeApprove instead of approve (audit issue #4) * forge install: solady v0.0.208 * inlines functions to save gas (audit issue #5) * improves validation of _from parameter / caller in ReceiverStargateV2 (audit issue #3) * removes receive function from StargateFacet (audit issue #6) * updates deploy script and redeploys ReceiverStargateV2 to staging (OPT) * adds a check that ensures receiver addresses match in case of no dst call * redeployed to polygon staging * confi: updates stargate config (adds missing networks/addresses) * mainnet deployments * Deploy ReceiverStargateV2 * update logs * deploy to bsc * deploy to prod --------- Co-authored-by: Ed Zynda <ezynda3@gmail.com> Co-authored-by: Leonardo Cascianelli <leo@li.finance>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.