feat(wallet-management): add support for base account #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! This is your new endopint: https://d787521b.widget-lf14696add.pages.dev |
tomiiide
requested review from
chybisov and
effie-ms
and removed request for
chybisov
chybisov
reviewed
Jul 29, 2025
@chybisov Yeah we do for one reason, it is the only way to connect with the Coinbase app wallet on mobile. 
However, the Coinbase wallet automatically connects to an existing base account connection, and also give you an option to login in to one during the auth flow. (which makes things a bit confusing) Also, we should rename the Coinbase wallet to the Base App, and update the logo. |
|
@tomiiide, ah I see, they will probably merge them at some point, but for now, let's keep both. Thank you! |
chybisov
approved these changes
Jul 29, 2025
|
Just got an update 😁
|
effie-ms
approved these changes
Jul 30, 2025
|
Hey! This is your new endopint: https://868164e0.widget-lf14696add.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira task is linked to this PR?
https://lifi.atlassian.net/browse/LF-14696
Why was it implemented this way?
It was implemented the standard way we implement these kinds of wallets.
Visual showcase (Screenshots or Videos)
Checklist before requesting a review