Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

ActiveSupport 3.2 #47

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants

gems:

  • inserted group :development with rake and minitest gems
  • removed thor from gemspec (it seems to be not used)
  • updated gems (activesupport 3.2)

It seems that tests are all passing now. The major modification was to replace class_inheritable_accessor with class_attribute

Sorry, I didn't noticed thor was used for generators. I'll open another pull request without touching thor :)

Vasfed commented Mar 20, 2012

same changes are also in #45 ...

wtn commented Mar 20, 2012

Is there a reason to block people from using these mods with activerecord/activesupport 3.1?

That's when the new methods were added and the old ones were deprecated… Not sure why your patches are restrictive.

Vasfed commented Mar 20, 2012

class_attribute was introduced in 3.0 as i remember, but actually we can do some respond_to-magic and loosen dependencies to somewhere near >=2.1

Yes, you are right indeed.
Sorry for my noobbish pull requests of yesterday. I updated the other pull request I created yesterday (#48) with another commit that reenable activesupport 3.0.9 in gemspec.

wtn commented Mar 22, 2012

Nice :)

I'll delete mine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment