Skip to content

Pratik
lifo

Organizations

@rails @basecamp @rack
Mar 4, 2016
lifo opened pull request rails/rails#24056
@lifo
Fix ActionCable.Subscriptions#create
1 commit with 2 additions and 0 deletions
Mar 4, 2016
Mar 4, 2016
Mar 4, 2016
lifo commented on commit rails/rails@f1c93ed828
@lifo

@javan I think ActionCable.Subscriptions#create should always return the Subscription object. We expect that in our apps as well.

Mar 3, 2016
lifo commented on commit rails/rails@fc1b32f8d1
@lifo

👍

Feb 26, 2016
lifo opened pull request rails/rails#23916
@lifo
Always use redis_connector to create redis connections
1 commit with 6 additions and 2 deletions
Feb 23, 2016
@lifo
Feb 22, 2016
lifo commented on pull request rails/rails#23813
@lifo

@jeremy Yeah, I thought about removing those faye-websocket switch+revert commits. But it can be useful in case we want to revert that change in th…

Feb 22, 2016
lifo commented on pull request rails/rails#23813
@lifo

What's the benefit of squashing the commits?

Feb 22, 2016
lifo opened pull request rails/rails#23813
@lifo
Improve Action Cable reconnection reliability
12 commits with 51 additions and 7 deletions
Feb 22, 2016
@lifo
Feb 22, 2016
lifo pushed to master at lifo/rails
@lifo
Feb 22, 2016
@lifo
  • @lifo 16e7b1b
    Revert "Move back to faye-websocket for handling cable connections"
Feb 19, 2016
@lifo
  • @lifo 94d979e
    Log ConnectionMonitor connect
Feb 19, 2016
@lifo
  • @lifo 926218a
    Confirm connection monitor subscription on open
Feb 18, 2016
@lifo
  • @lifo d787837
    Treat 'closing' state as closed.
Feb 17, 2016
@lifo
Feb 17, 2016
lifo closed pull request lifo/rails#1
@lifo
Add client-side console logging to help debug reconnect issues
lifo added javan to lifo/rails
Feb 17, 2016
lifo created branch faye-websocket at lifo/rails
Feb 13, 2016
Feb 13, 2016
Something went wrong with that request. Please try again.