Skip to content
Commits on May 18, 2016
  1. @Shadowfiend

    Merge pull request #1798 from serveace/csp-report-json

    Parse CSP report as JSON
    
    Chrome sends csp-report as application/csp-report, which
    breaks default json parsing since it checks for content-type
    to be json. We switch to forcedBodyAsJson, which ignores
    the content-type.
    Shadowfiend committed May 18, 2016
  2. @serveace

    Parse CSP report as JSON

    Chrome sends csp-report as application/csp-report, which breaks default json parsing.
    serveace committed May 17, 2016
Commits on May 4, 2016
  1. @Shadowfiend

    Merge pull request #1789 from lift/tcn_issue_1788

    Use S.appendGlobalJs for JavaScript in XmlOrJsCmd.outSpan
    Shadowfiend committed May 4, 2016
Commits on May 3, 2016
  1. @eltimn
Commits on Apr 29, 2016
  1. @tuhlmann

    Merge pull request #1787 from lift/uhl_issue_1787

    Add Record and MetaRecord asJObject methods
    tuhlmann committed Apr 29, 2016
Commits on Apr 28, 2016
  1. @eltimn
  2. @tuhlmann
Commits on Apr 16, 2016
  1. @farmdawgnation
Commits on Apr 9, 2016
  1. @Shadowfiend

    Merge pull request #1785 from lift/gitter-notifications-test

    Add some gitter notification settings.
    Shadowfiend committed Apr 9, 2016
  2. @farmdawgnation
Commits on Apr 4, 2016
  1. @fmpwizard

    Merge pull request #1783 from lift/party-foul

    Party Foul: Fix JsCmd handling of extracted event JS
    fmpwizard committed Apr 3, 2016
Commits on Mar 29, 2016
  1. @Shadowfiend

    Don't include empty event JS in fixed HTML output.

    When a JsCmd fixed HTML that included no event JS, it was still generating some
    empty extra JS. We now drop that: no event JS means no additional JS is
    appended at all.
    Shadowfiend committed Mar 29, 2016
  2. @Shadowfiend

    & with Noop returns the original JsCmd unchanged.

    Before, &-ing with a Noop would return a CmdPair including the original JsCmd
    and the Noop. But the point of Noop is it doesn't do anything, so rather than
    track it, we now return the original JsCmd unchanged.
    Shadowfiend committed Mar 29, 2016
  3. @Shadowfiend
  4. @Shadowfiend

    Append extracted events to returned JS in fixHtmlAndJs.

    Before, we were using a global appendJs for these events. However, fixHtmlAndJs
    already provides a mechanism for returning additional JS. We now use it.
    
    The previous behavior would result in extracted events being appended to the
    response (page or AJAX) even if the JsCmd that invoked fixHtmlAndJs was never
    actually sent down to the client. This behavior correctly makes the extracted
    event JS part of the JsCmd, so that it can be sent down only with that JsCmd.
    Shadowfiend committed Mar 29, 2016
Commits on Mar 17, 2016
  1. @Shadowfiend

    Merge pull request #1779 from lift/rc-fixes

    RC Fixes
    
    Couple of fixes so we can get the RC out the door:
     - Fix WebSpec's broken fragments.
     - Props respects whereToLook again and now has a test verifying that this
       works as expected.
    
    Also some small deprecation, spec, and scaladoc-related fixes.
    Shadowfiend committed Mar 17, 2016
Commits on Mar 15, 2016
  1. @Shadowfiend

    Correct omniauth-related specs.

    We were looking up system properties with the same name in two tests, which led
    to potential concurrency issues running those tests in parallel.
    Shadowfiend committed Mar 15, 2016
  2. @Shadowfiend

    Correct the run-mode-locking spec.

    It wasn't locking the run mode, so it wasn't really testing what it wanted to
    be testing.
    Shadowfiend committed Mar 15, 2016
  3. @Shadowfiend

    Emphasize a few things in the Props scaladocs.

    In particular, things that need to be set before Props are accessed.
    Shadowfiend committed Mar 15, 2016
  4. @Shadowfiend

    Make providers respect whereToLook.

    Due to how we'd structured provider loading, we eagerly looked up props when
    the Props singleton was first instantiated. This prevented the customization
    point that is updating `whereToLook` from working.
    
    We now indirect providers access a bit so as to lazy-load providers when we
    first access a property, and then we can respect whereToLook and look things up
    as the user wants them.
    
    Also added a test verifying this behavior.
    Shadowfiend committed Mar 15, 2016
Commits on Mar 13, 2016
  1. @Shadowfiend
  2. @Shadowfiend

    WebSpec correctly adds fragments it creates.

    The WebSpec extension classes like SessionSpecification were creating
    fragments, but weren't adding them to the fragments to run, so those
    tests were never getting executed.
    
    We now properly add the generated fragments to the list of fragments to run.
    Shadowfiend committed Mar 13, 2016
Commits on Mar 12, 2016
  1. @Shadowfiend

    Merge pull request #1773 from lift/raise-the-roof

    Dependency version bumps in advance of 3.0-RC1.
    
    These are version bumps I want to submit for 3.0-RC1. They spawn a few deprecation warnings in the compile cycle so it may be worth taking care of those before merging.
    
    AFAICT these are the highest version bumps I can make without breaking the compile. I also bumped the version of Scala while I was at it.
    Shadowfiend committed Mar 12, 2016
Commits on Mar 5, 2016
  1. @farmdawgnation

    Provide some stub implementations where we can.

    We can't everywhere, particularly generic methods that return a T. :/
    farmdawgnation committed Mar 5, 2016
  2. @farmdawgnation
Commits on Mar 4, 2016
  1. @farmdawgnation
  2. @farmdawgnation
Commits on Mar 1, 2016
  1. @Shadowfiend

    Fix TimeHelpersSpec specs2-related compile issue.

    specs2 stopped supporting mixing MatchersImplicits directly into something that
    extends Scope, but we can just import the implicits via the MatchersImplicits
    singleton.
    Shadowfiend committed Feb 29, 2016
  2. @Shadowfiend

    Fix failing CanResolveAsync compile.

    I think specs2 used to provide a default Scala execution context, but it no
    longer does so we had to import our own.
    Shadowfiend committed Feb 29, 2016
  3. @Shadowfiend

    Mode auto-detection failed for latest specs2.

    specs2 can occasionally run in a context where our current stack trace
    inspection doesn't *quite* work.
    Shadowfiend committed Feb 29, 2016
  4. @Shadowfiend

    Bump specs2 to 3.7, scalaz to 7.2.0, fix everything.

    There were about 16 million compile and execution errors... They're fixed.
    Mostly. Sort of. Hopefully.
    Shadowfiend committed Feb 28, 2016
Commits on Feb 27, 2016
  1. @farmdawgnation
Commits on Feb 24, 2016
  1. @farmdawgnation
Commits on Feb 21, 2016
  1. @farmdawgnation

    Merge pull request #1772 from lift/joe-noop-ignore

    Filter out empty lines in CmdPair.toJsCmd.
    farmdawgnation committed Feb 21, 2016
Commits on Feb 20, 2016
  1. @farmdawgnation

    Merge pull request #1766 from lift/msf-json-lists-1518

    Convert \\ to always return a JObject.
    
    Previously, you would sometimes get a JObject and sometimes get a regular JValue. Now for sanity™ we always return a JObject.
    farmdawgnation committed Feb 20, 2016
Something went wrong with that request. Please try again.