Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Remove Mapper and Record safe_# due to performance costs #1196

Closed
hoffrocket opened this Issue · 2 comments

2 participants

@hoffrocket
Collaborator

noticed that instantiation of Record instances is
pretty expensive (in terms of wall clock time) due to the Safe.next
call during construction.

see discussion: https://groups.google.com/group/liftweb/browse_thread/thread/f6a74d92d895f6ce/e8d3ef6ceced6ee8#e8d3ef6ceced6ee8

@github-importer

(In [[r:c006de920eee45cc4522ecd9c1559c629dfd4eb0]]) use dynamic "safe_#" instead of random long

Closes #1196

Remove instance field which stored random long in Mapper and Record
in favor of pseudo unique System.identityHashCode at call time for
purpose of runSafe{} blocks

Branch: jon-nosafe-1196

@hoffrocket hoffrocket was assigned
@pbrant pbrant referenced this issue from a commit in pbrant/framework
@hoffrocket hoffrocket use dynamic "safe_#" instead of random long
Closes #1196

Remove instance field  which stored random long in Mapper and Record
in favor of pseudo unique System.identityHashCode at call time for
purpose of runSafe{} blocks
c006de9
@hoffrocket hoffrocket referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.