Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove Mapper and Record safe_# due to performance costs #1196

Closed
hoffrocket opened this Issue Feb 10, 2012 · 2 comments

Comments

Projects
None yet
2 participants
Member

hoffrocket commented Feb 10, 2012

noticed that instantiation of Record instances is
pretty expensive (in terms of wall clock time) due to the Safe.next
call during construction.

see discussion: https://groups.google.com/group/liftweb/browse_thread/thread/f6a74d92d895f6ce/e8d3ef6ceced6ee8#e8d3ef6ceced6ee8

(In [[r:c006de920eee45cc4522ecd9c1559c629dfd4eb0]]) use dynamic "safe_#" instead of random long

Closes #1196

Remove instance field which stored random long in Mapper and Record
in favor of pseudo unique System.identityHashCode at call time for
purpose of runSafe{} blocks

Branch: jon-nosafe-1196

@ghost ghost assigned hoffrocket Mar 1, 2012

pbrant pushed a commit to pbrant/framework that referenced this issue May 8, 2012

use dynamic "safe_#" instead of random long
Closes #1196

Remove instance field  which stored random long in Mapper and Record
in favor of pseudo unique System.identityHashCode at call time for
purpose of runSafe{} blocks

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment