Dissapearing attributes when None values are used on other attributes #1262

Closed
robmv opened this Issue May 2, 2012 · 0 comments

Comments

Projects
None yet
3 participants

robmv commented May 2, 2012

Attributes with None value on XML literals cause that other attributes disappear from the final output when using HTML 5 Serialization. Test code:

val html =
Html5.write(Group(html), w, false, !LiftRules.convertToEntity.vend)
w.toString

The output string does not have the id attribute when data-source is set to None

the bug is in Html5Writer.writeAttributes(MetaData,Writer), changing from:

case md if (null eq md.value) => // issue 807. Don't do empty

to

case md if (null eq md.value) => writeAttributes(md.next, writer)

solves this problem, I have this fix running for a few weeks without causing any other bug in my daily coding

Group discussion:

https://groups.google.com/forum/#!msg/liftweb/Y0DEKgemWAQ/CUB0oSmwFNwJ

jeppenejsum was assigned May 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment