Don't covert entities in certain cases #1368

Open
dpp opened this Issue Nov 26, 2012 · 1 comment

Comments

Projects
None yet
4 participants
Owner

dpp commented Nov 26, 2012

When the "don't convert entity" flag is passed to the Html5 writer... don't convert entities:

      case er: EntityRef if convertAmp =>
        HtmlEntities.entMap.get(er.entityName) match {
          case Some(chr) if chr.toInt >= 128 => writer.append(chr)
          case _ => {
            val sb = new StringBuilder()
            er.buildString(sb)
            writer.append(sb)
          }
        }


      case er: EntityRef =>
        val sb = new StringBuilder()
        er.buildString(sb)
        writer.append(sb)

dpp was assigned Nov 26, 2012

Shadowfiend added this to the 3.0-M1 milestone May 13, 2014

@farmdawgnation farmdawgnation modified the milestone: 3.0-M2, 3.0-M3 Nov 26, 2014

@Shadowfiend Shadowfiend modified the milestone: 3.0-M3, 3.0-M4 Jan 14, 2015

@fmpwizard fmpwizard modified the milestone: 3.0-M4, 3.0-M6 Mar 22, 2015

@Shadowfiend Shadowfiend modified the milestone: 3.0-M6, 3.0-M7 Jul 26, 2015

@Shadowfiend Shadowfiend modified the milestone: 3.0-M7, 3.1 Nov 30, 2015

Owner

Shadowfiend commented Dec 12, 2016

Believe this happens in Html5Writer.writeAttributes, in addition to the quoted segment of Html5Writer.write.

Shadowfiend removed this from the 3.1.0-RC1 milestone Apr 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment