Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #1346: JObjectField doesn't serialize to BSON #1369

Closed
wants to merge 2 commits into from

Conversation

ultramiraculous
Copy link
Contributor

I previously asked for a fix for Issue #1346, but I already had code written for a fix. Let me know if I need to do anything else

@eltimn
Copy link
Member

eltimn commented Nov 30, 2012

Thanks for the submission. However, there are a couple of problems;

  • To convert JValue to DBObject and vice versa, using JObjectParser is necessary to take advantage of lift-json's features
  • Instead of changing BsonRecord to check for JValue, it'd be better to add MongoFieldFlavor to JObjectField

I have a branch with these changes and I will be issuing a pull req shortly.

@eltimn eltimn closed this Nov 30, 2012
@ultramiraculous
Copy link
Contributor Author

Cool, thanks for the feedback and the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants