Skip to content

Remove lift-couchdb from framework. It is now a lift module.#1383

Closed
arashi01 wants to merge 1 commit into
lift:masterfrom
arashi01:LI-2
Closed

Remove lift-couchdb from framework. It is now a lift module.#1383
arashi01 wants to merge 1 commit into
lift:masterfrom
arashi01:LI-2

Conversation

@arashi01

Copy link
Copy Markdown
Contributor

Related mailing list discussion

@lkuczera

Copy link
Copy Markdown
Member

+1
On Dec 18, 2012 12:35 PM, "Ali Salim Rashid" notifications@github.com
wrote:

Related mailing list discussionhttps://groups.google.com/d/msg/liftweb/HCp7kO4aRlo/ruQYYTXqjjIJ

You can merge this Pull Request by running:

git pull https://github.com/arashi01/framework LI-2

Or view, comment on, or merge it at:

#1383
Commit Summary

  • Remove lift-couchdb from framework. It is now a lift module.

File Changes

  • M contributors.md (6)
  • _D_persistence/couchdb/src/main/scala/net/liftweb/couchdb/CouchRecord.scala
    (252)
  • _D_persistence/couchdb/src/main/scala/net/liftweb/couchdb/Database.scala (254)
  • _D_persistence/couchdb/src/main/scala/net/liftweb/couchdb/DispatchJSON.scala
    (69)
  • _D_persistence/couchdb/src/main/scala/net/liftweb/couchdb/DocumentHelpers.scala
    (108)
  • _D_persistence/couchdb/src/main/scala/net/liftweb/couchdb/JSONRecord.scala
    (281)
  • _D_persistence/couchdb/src/test/scala/net/liftweb/couchdb/CouchDatabaseSpec.scala
    (92)
  • _D_persistence/couchdb/src/test/scala/net/liftweb/couchdb/CouchDocumentSpec.scala
    (117)
  • _D_persistence/couchdb/src/test/scala/net/liftweb/couchdb/CouchQuerySpec.scala
    (197)
  • _D_persistence/couchdb/src/test/scala/net/liftweb/couchdb/CouchRecordSpec.scala
    (330)
  • _D_persistence/couchdb/src/test/scala/net/liftweb/couchdb/JsonRecordSpec.scala
    (171)
  • M project/Build.scala (8)
  • M project/Dependencies.scala (1)

Patch Links

@d6y

d6y commented Dec 18, 2012

Copy link
Copy Markdown
Member

I've forked the module into http://github.com/liftmodules/couchdb/ and will be test building that over the next few days.

@fmpwizard

Copy link
Copy Markdown
Member

@d6y let us know once there is a version of the module on sonatype build for lift 2.5-SNAPSHOT and then I can rebase this to master, so we don't leave users of couchdb-record out of luck while they are on the bleeding edge :)

Thanks for the work!

@d6y

d6y commented Dec 19, 2012

Copy link
Copy Markdown
Member

I've performed an initial publish of the module for 2.5-SNAPSHOT. E.g.,

https://oss.sonatype.org/content/repositories/snapshots/net/liftmodules/lift-couchdb_2.9.2/2.5-SNAPSHOT-1.0-SNAPSHOT/

The dependency will be:

 "net.liftmodules" %% "lift-couchdb" % "2.5-SNAPSHOT-1.0-SNAPSHOT"

Probably.

@fmpwizard

Copy link
Copy Markdown
Member

awesome! I'll rebase the pull request to remove couchdb later tonight (EST)

@fmpwizard

Copy link
Copy Markdown
Member

Breaking changes:

The couchdb-record implementation moved to the liftmodules repository. This means that you will need to change your import lines from net.liftweb.record.couchdb to net.liftmodules.couchdb

and to bring this dependency (using sbt), you will need:

"net.liftmodules" %% "lift-couchdb" % "2.5-SNAPSHOT-1.0-SNAPSHOT"

(This is the text we'll include on the next milestone release of Lift, feel free to add anything es=lse you think we should add.)

@fmpwizard

Copy link
Copy Markdown
Member

rebased to master

@fmpwizard fmpwizard closed this Dec 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants