Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

contextPath is always empty string for CometActors #1495

Closed
fmpwizard opened this Issue · 5 comments

4 participants

@fmpwizard fmpwizard was assigned
@farmdawgnation farmdawgnation modified the milestone: 2.6-M4, 2.6-M3
@Shadowfiend Shadowfiend modified the milestone: 3.0-M2, 2.6-M4
@Shadowfiend
Owner

Punting this to 3.0-M2.

@fmpwizard
Owner

just a heads up, looks like I have a fix for this, but It isn't ready for code review yet, works on a simple comet app, but I'd like to do more testing before asking for feedback.

@Shadowfiend
Owner

… That was completely bizarre. I was just looking at this issue* lol.

@andreak
Owner

Really cool!

@fmpwizard
Owner

@Shadowfiend in that case, I just pushed this branch diego_issue_1495

What this does is for CometActors, calling S.request gives you Empty, instead of the fake Req that we get by calling Req.nil.

This in turn let's S.contextPath do the right thing, and get the context path from the session.

The one thing I'm not too happy with is how I set the ThreadLocal that contains the current Req as null for the comet, on the other hand, ThreadLocals have a .box method that handles null values just fine.

Maybe I'll open a WIP PR so you can all see the changes using github's UI and we can discuss it more there

@fmpwizard fmpwizard closed this in #1613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.