New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ajaxPostTimeout isn't properly respected in server-side request handling #1617
Comments
+1 for letting 2.6 go out the door and making the fix in Lift-3, and possibly backport to 2.6.1 if that ever happens. |
I would normally agree with moving on to lift 3.0, but we currently have this PR which is for 2.6 (there is also a PR with those changes for 3.0 which is already merged or about to be merged). And then we have this one: #1613 which may be a good idea to also fix in 2.6 (I thought I saw an email or comment somewhere asking to backport it to 2.6 but can't find that email now)... found it, an email from Andreas:
so how about we get all these into 2.6, while holding it for a few more weeks, but then we know lift 2.6 is that much better :) |
👍 |
I have a patch (created with |
I would let Antonio or someone else confir this (I know I made a mess when I cherry-pick'ed commits from lift 2.6 to lift 3.0), but I think that in this case, what you would do is
As far as I know, this is the correct way to backport a commit from master to a different branch, but I'd wait and see what others have to say. once that works, you create a new branch |
I first cherry-picked, but as it produced conflicts I manually backported it as the changes was relatively small. |
Ok, so what's the story here? Has someone done work on this specific issue, or did we end up using this issue to discuss the merging of the others? Shall I create a PR for this particular issue? |
+1 for creating the pr On Wednesday, September 10, 2014, Antonio Salazar Cardozo <
Diego Medina |
…used as is on ScriptRenderer, so the client should just get the same value in both cases (well, ajaxPostTimeout should be the same timeout + 500ms) fixes #1617
#1637 was merged. I'm closing this accordingly. |
While investigating #1614, I uncovered a mistake in the retry handling code: we actually multiply the
ajaxPostTimeout
by 1000 server-side, so we basically tie up a request thread per retry until the original request completes correctly, even if the original requests have been timed out correctly by the browser.The fix for this is trivial, but it's a bug that's been around since the 2.5 release without complaint, so I'm thinking it may be worth letting 2.6 go out the door in final form given its Scala 2.11 support and such, and making the fix in Lift 3… Thoughts?
The text was updated successfully, but these errors were encountered: