Add caching to Paginator #868

dchenbecker opened this Issue Jan 27, 2011 · 2 comments


None yet
4 participants

dchenbecker commented Jan 27, 2011

Original email:

While I was testing for #616 I ran into some really awful performance with pagination. The root cause is that H2 is taking a long time on queries, but the fact that the "count" and "page" members in Paginator are defs means that I was hitting the slow query multiple times for each render (8 times for "count" in my read of the code). I was wondering if we should go optionally cache the result of "page" in a RequestVar and base "count" on that to avoid hitting the database so many times. Yes, DBs have query caches and other things that should mitigate this, but still that's at least 8 round trips to the database for every page view.

Per DPP this should use a TransientRequestVar

This comment has been minimized.

Show comment Hide comment

This comment has been minimized.

Show comment Hide comment

@ghost ghost assigned dchenbecker Mar 1, 2012

@Shadowfiend Shadowfiend added this to the 3.0-M1 milestone May 10, 2014

@farmdawgnation farmdawgnation modified the milestones: 3.0-M2, 3.0-M3 Nov 26, 2014

@Shadowfiend Shadowfiend modified the milestone: 3.0-M3 Jan 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment