drop setFromAny from record API #887

Open
harryh opened this Issue Feb 9, 2011 · 14 comments

6 participants

@harryh
Lift Web Framework member

It's a pretty bad/annoying API that was developed a looooong time ago and has outlived it's usefulness. Will require a deprecation cycle.

Possibly should be dropped from Mapper API as well (though I personally care less about that).

@Shadowfiend Shadowfiend added this to the 2.6-M4 milestone May 10, 2014
@Shadowfiend Shadowfiend added the P:High label May 10, 2014
@Shadowfiend
Lift Web Framework member

If we're going to do this, we need to get the deprecation wheels moving in 2.6 and remove it in 3.0.

@Shadowfiend Shadowfiend removed the P:Normal label May 10, 2014
@farmdawgnation
Lift Web Framework member

Wowza, yeah. I'll add a deprecation warning for both.

@eltimn
Lift Web Framework member

What's the plan to replace this? It's used quite a bit.

@farmdawgnation
Lift Web Framework member

In my mind, it'd be ideal for the client code to do the type check on its end to figure out what the any is. Do you agree or should we kick off a discussion on the ML?

@eltimn
Lift Web Framework member

It's used internally a lot. Pretty much every field uses it in their form element. Although, most of those could be replaced with setFromString or whatever's relevant to that Field.

I guess the one place I need a replacement is in BsonRecord.setFieldsFromDBObject since I don't have the type info. We may be able to get that info from the Field, though. I'll look into that as soon as I finish my other pull req.

@Shadowfiend
Lift Web Framework member

We definitely shouldn't deprecate unless we have a clear plan for getting rid of it. I noticed it was pretty thoroughly baked in as well. Some research is probably a good idea.

@eltimn
Lift Web Framework member

I'll go trough the Record Fields and see if I can rework BsonRecord.setFieldsFromDBObject.

For squeryl-record we should probably have @davewhittaker take a look.

Not sure who should handle Mapper, I'm not that familiar with it.

@farmdawgnation
Lift Web Framework member

I'm going to kick this off the M4 milestone since it looks like this may be a bit more substantial work than just adding @deprecated. :/ Should probably be planned for M5 though.

@farmdawgnation farmdawgnation modified the milestone: 2.6-M5, 2.6-M4 Jun 1, 2014
@Shadowfiend
Lift Web Framework member

Yeah, when I was assigning these around I wasn't planning milestones, just using M4 to mark things we eventually wanted in 2.6.

@Shadowfiend
Lift Web Framework member

Any updated thoughts here as we prep for an RC?

@farmdawgnation
Lift Web Framework member

Bupkis. :( No. I forgot about it.

@Shadowfiend Shadowfiend modified the milestone: 2.6-RC1, 2.6-RC2 Jul 31, 2014
@farmdawgnation
Lift Web Framework member

This probably isn't going to make it into 2.6...

@Shadowfiend
Lift Web Framework member

Heh. Yeah, RC means we're done with changes like this.

@Shadowfiend Shadowfiend modified the milestone: 2.6-RC2, 3.0-M2 Aug 19, 2014
@farmdawgnation farmdawgnation modified the milestone: 3.0-M2, 3.0-M3 Nov 26, 2014
@Shadowfiend Shadowfiend modified the milestone: 3.0-M3, 3.0-M4 Jan 14, 2015
@fmpwizard fmpwizard modified the milestone: 3.0-M4, 3.0-M6 Mar 22, 2015
@Shadowfiend Shadowfiend modified the milestone: 3.0-M6, 3.0-M7 Jul 26, 2015
@Shadowfiend Shadowfiend modified the milestone: 3.1, 3.0-M7 Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment