Skip to content
This repository

lift-mapper depends on derby #1181

Merged
merged 1 commit into from almost 2 years ago

5 participants

Jeppe Nejsum Madsen github-importer Indrajit Raychaudhuri Diego Medina David Pollak
Jeppe Nejsum Madsen
Owner

No description provided.

Jeppe Nejsum Madsen
Owner

It also depends on h2

Both should be test dependencies

Indrajit Raychaudhuri
Owner

Currently they are in runtime scope, which means they aren't really compile time dependency. Having them in runtime is meant to be a hint for the downstream libraries and apps.

Just curious, are they affecting the way apps see these runtime dependencies?

Diego Medina
Owner

I just checked and whatI notice is that if you depend on mapper, but do not depend on h2 nor derby, derby will be downloaded and be in the classpath for my project.
After doing a sbt package, I then looked inside the war and I found the derby jar is there, as well as h2.

Diego Medina fmpwizard closed this in 21ac622 June 30, 2012
Diego Medina fmpwizard reopened this June 30, 2012
David Pollak dpp merged commit f6bdd84 into from July 01, 2012
David Pollak dpp closed this July 01, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Jul 01, 2012
Diego Medina Fixed #1181 - lift-mapper depends on derby 21ac622
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 2 additions and 2 deletions. Show diff stats Hide diff stats

  1. 4  project/Dependencies.scala
4  project/Dependencies.scala
@@ -67,8 +67,8 @@ object Dependencies {
67 67
 
68 68
   // Runtime scope:
69 69
   // Scope provided in runtime, available only in runtime and test classpath, not compile classpath, non-transitive by default.
70  
-  lazy val derby      = "org.apache.derby" % "derby" % "10.7.1.1" % "runtime" //% "optional"
71  
-  lazy val h2database = "com.h2database"   % "h2"    % "1.2.147"  % "runtime" //% "optional"
  70
+  lazy val derby      = "org.apache.derby" % "derby" % "10.7.1.1" % "test" //% "optional"
  71
+  lazy val h2database = "com.h2database"   % "h2"    % "1.2.147"  % "test" //% "optional"
72 72
 
73 73
   // Aliases
74 74
   lazy val h2 = h2database
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.