Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make session loss handling more flexible for ajax and comet #1285

Merged
merged 7 commits into from Jul 1, 2012
Commits on Jun 20, 2012
Commits on Jun 21, 2012
  1. redirectAsyncOnSessionLoss calls client-side functions.

    Shadowfiend committed Jun 21, 2012
    The client-side functions are called liftAjax.sessionLost and
    liftComet.sessionLost, and can be overridden by the user. We still need
    to hook noCometSessionPage into these somehow so we can have backwards
    compatibility.
Commits on Jun 25, 2012
  1. Add LiftRules noCometSessionCmd/noAjaxSessionCmd.

    Shadowfiend committed Jun 25, 2012
    These are the JsCmds that will be sent to the client when a session is
    missing for a comet or ajax request, respectively. For comets, no comet
    session is a state where a comet request comes in with no associated
    session OR with a session that has no associated CometActors (typically
    this happens on server reload).
  2. Add default liftAjax. and liftComet.lift_sessionLoss.

    Shadowfiend committed Jun 25, 2012
    The default implementation of liftComet.lift_sessionLoss uses
    LiftRules.noCometSessionPage to do a redirect, while liftAjax's does a
    page reload (which is what we'd rather have liftComet's do, but we need
    to be backwards-compatible with noCometSessionPage).
Commits on Jun 26, 2012
  1. Add @deprecated for redirectOnAjaxSessionLoss assignment.

    Shadowfiend committed Jun 26, 2012
    Before we had only deprecated the read, not the write.