Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Deprecate bundled jQuery #1287

Closed
wants to merge 1 commit into from

3 participants

@fmpwizard
Owner

Based on this thread
https://groups.google.com/d/topic/liftweb/l3M8yNaAVX8/discussion
we will deprecate the "very old" bundled jQuery and offer out users a couple of alternatives.

1- Let them include jQuery in their own projects (like in webapp/js/ )
2- Let them use one of the CDN hosted urls (like Google, etc)
3- Use the lightweight module Peter Petersson wrote.

@fmpwizard fmpwizard was assigned
@karma4u101
Collaborator

The module is prepared for usage by the lift module build system so can we hook this module up to the lift module build system?
My primary concern is that it is currently hosted at my nexus repository and not in a generally accessible repository.
Maybe move the module [1] into the Lift modules?

[1] https://github.com/karma4u101/lift-jquery-module

@fmpwizard
Owner

Sounds like a good idea, please email the lift list so we get it on the lift module.

@d6y
Owner
d6y commented

Build created for this module. I've also added it to the "build hub" project which builds all the modules. It succeeded (build 19) and has published the module to Central Snapshot (e.g., see repo for 2.9.2).

@fmpwizard fmpwizard closed this in 868cf36
@fmpwizard fmpwizard reopened this
@fmpwizard fmpwizard closed this in 7962c84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 1, 2012
  1. @fmpwizard
This page is out of date. Refresh to see the latest.
View
3  web/webkit/src/main/scala/net/liftweb/http/js/jquery/JQueryArtifacts.scala
@@ -133,6 +133,7 @@ trait JQueryArtifacts extends JSArtifacts {
info.failFunc.map("error : " + _).toList mkString ("{ ", ", ", " }")
}
+@deprecated("Either include your own jQuery or use https://github.com/karma4u101/lift-jquery-module")
case object JQuery13Artifacts extends JQueryArtifacts {
override def pathRewriter: PartialFunction[List[String], List[String]] = {
case "jquery.js" :: Nil if Props.devMode => List("jquery-1.3.2.js")
@@ -140,7 +141,7 @@ case object JQuery13Artifacts extends JQueryArtifacts {
}
}
-
+@deprecated("Either include your own jQuery or use https://github.com/karma4u101/lift-jquery-module")
case object JQuery14Artifacts extends JQueryArtifacts {
override def pathRewriter: PartialFunction[List[String], List[String]] = {
case "jquery.js" :: Nil if Props.devMode => List("jquery-1.4.4.js")
Something went wrong with that request. Please try again.