Added java.sql.Timestamp to net.liftweb.json Extraction #1308

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@kevg
Contributor

kevg commented Aug 16, 2012

I ran into a problem where a Mapper MappedDateTime was not being serialized by net.liftweb.json.Extraction. It turns out this is because MappedDateTime.is returns a java.sql.Timestamp, which although is a subclass of java.util.Date, lift json did not support.

@Shadowfiend

This comment has been minimized.

Show comment
Hide comment
@Shadowfiend

Shadowfiend Aug 16, 2012

Member

Note that we can't accept pull requests. See http://liftweb.net/community for more.

Member

Shadowfiend commented Aug 16, 2012

Note that we can't accept pull requests. See http://liftweb.net/community for more.

@kevg

This comment has been minimized.

Show comment
Hide comment
@kevg

kevg Aug 16, 2012

Contributor

Okay. There are some well known patterns you can consider that many Eclipse & Apache projects use: When a patch is submitted, a set of questions are asked to the person such as the code's provenance, etc.

Contributor

kevg commented Aug 16, 2012

Okay. There are some well known patterns you can consider that many Eclipse & Apache projects use: When a patch is submitted, a set of questions are asked to the person such as the code's provenance, etc.

@Shadowfiend

This comment has been minimized.

Show comment
Hide comment
@Shadowfiend

Shadowfiend Aug 16, 2012

Member

There's been a multitude of discussions about this on the list; please go ahead and peruse them for more details.

Member

Shadowfiend commented Aug 16, 2012

There's been a multitude of discussions about this on the list; please go ahead and peruse them for more details.

@dpp

This comment has been minimized.

Show comment
Hide comment
@dpp

dpp Aug 16, 2012

Member

We have chosen a set of patterns and rules for contribution and we advertise them. We do not have any plans to revisit them. Thanks.

Member

dpp commented Aug 16, 2012

We have chosen a set of patterns and rules for contribution and we advertise them. We do not have any plans to revisit them. Thanks.

@d6y

This comment has been minimized.

Show comment
Hide comment
@d6y

d6y Aug 16, 2012

Member

To help avoid confusions, I could look at modifying the first section of https://github.com/lift/framework/blob/master/README.md to highlight the policy.

Member

d6y commented Aug 16, 2012

To help avoid confusions, I could look at modifying the first section of https://github.com/lift/framework/blob/master/README.md to highlight the policy.

@fbettag

This comment has been minimized.

Show comment
Hide comment
@fbettag

fbettag Aug 16, 2012

Member

I think this is a good idea, since most of the people writing patches would be looking at the GitHub Repo's first few paragraphs rather than the last paragraph and then the website :)

Member

fbettag commented Aug 16, 2012

I think this is a good idea, since most of the people writing patches would be looking at the GitHub Repo's first few paragraphs rather than the last paragraph and then the website :)

@dpp

This comment has been minimized.

Show comment
Hide comment
@dpp

dpp Aug 16, 2012

Member

Great idea!

Member

dpp commented Aug 16, 2012

Great idea!

d6y added a commit that referenced this pull request Aug 17, 2012

Added prominent section indicating no pull requests, in relation to c…
…omments in #1308

Also corrected a typo and updated link to the new modules repositories.
@kevg

This comment has been minimized.

Show comment
Hide comment
@kevg

kevg Aug 20, 2012

Contributor

Thanks.

Contributor

kevg commented Aug 20, 2012

Thanks.

d6y added a commit that referenced this pull request Aug 21, 2012

Added prominent section indicating no pull requests, in relation to c…
…omments in #1308

Also corrected a typo and updated link to the new modules repositories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment