Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added java.sql.Timestamp to net.liftweb.json Extraction #1308

Closed
wants to merge 1 commit into from
Closed

Added java.sql.Timestamp to net.liftweb.json Extraction #1308

wants to merge 1 commit into from

Conversation

kevg
Copy link
Contributor

@kevg kevg commented Aug 16, 2012

I ran into a problem where a Mapper MappedDateTime was not being serialized by net.liftweb.json.Extraction. It turns out this is because MappedDateTime.is returns a java.sql.Timestamp, which although is a subclass of java.util.Date, lift json did not support.

@Shadowfiend
Copy link
Member

Note that we can't accept pull requests. See http://liftweb.net/community for more.

@kevg
Copy link
Contributor Author

kevg commented Aug 16, 2012

Okay. There are some well known patterns you can consider that many Eclipse & Apache projects use: When a patch is submitted, a set of questions are asked to the person such as the code's provenance, etc.

@Shadowfiend
Copy link
Member

There's been a multitude of discussions about this on the list; please go ahead and peruse them for more details.

@dpp
Copy link
Member

dpp commented Aug 16, 2012

We have chosen a set of patterns and rules for contribution and we advertise them. We do not have any plans to revisit them. Thanks.

@d6y
Copy link
Member

d6y commented Aug 16, 2012

To help avoid confusions, I could look at modifying the first section of https://github.com/lift/framework/blob/master/README.md to highlight the policy.

@fbettag
Copy link
Member

fbettag commented Aug 16, 2012

I think this is a good idea, since most of the people writing patches would be looking at the GitHub Repo's first few paragraphs rather than the last paragraph and then the website :)

@dpp
Copy link
Member

dpp commented Aug 16, 2012

Great idea!

d6y added a commit that referenced this pull request Aug 17, 2012
…omments in #1308

Also corrected a typo and updated link to the new modules repositories.
@kevg
Copy link
Contributor Author

kevg commented Aug 20, 2012

Thanks.

d6y added a commit that referenced this pull request Aug 21, 2012
…omments in #1308

Also corrected a typo and updated link to the new modules repositories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants