Only catch Exception #1322

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@nafg

Scala 2.10 warns on catch { case x => ... }, since it will catch all Throwables, including OutOfMemory, etc. Usually you want case x: Exception. This adds it, in only a few places.

@fmpwizard
Lift Web Framework member

+1

@fmpwizard
Lift Web Framework member

if this compiles in 2.9.1, could you rebase it onto master?

@nafg nafg closed this Oct 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment