Removed all the open_! calls #1333

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@fmpwizard
Member

We deprecated open_!, so I'm replacing it for openOrThrowException or map/flatMap/etc where appropriate.

@fmpwizard fmpwizard was assigned Oct 13, 2012
@nafg
nafg commented Oct 14, 2012

Can we just use openOr(sys.error(...))?

On Sat, Oct 13, 2012 at 12:45 AM, Diego Medina notifications@github.comwrote:

We deprecated open_!, so I'm replacing it for openOrThrowException or
map/flatMap/etc where appropriate.


Reply to this email directly or view it on GitHubhttps://github.com/lift/framework/issues/1333.

@tuhlmann
Member

There was a discussion a while ago with the tenor being that open_! is not looking enough dangerous to keep people from using it.
So we introduced openOrThrowException to make it explicit that an exception is thrown if the Box is Empty (or Failure).

Using openOr(sys.error) would I think make things not better.

Torsten.

Am 14.10.2012 um 04:51 schrieb nafg notifications@github.com:

Can we just use openOr(sys.error(...))?

On Sat, Oct 13, 2012 at 12:45 AM, Diego Medina notifications@github.comwrote:

We deprecated open_!, so I'm replacing it for openOrThrowException or
map/flatMap/etc where appropriate.


Reply to this email directly or view it on GitHubhttps://github.com/lift/framework/issues/1333.


Reply to this email directly or view it on GitHub.

@fmpwizard
Member

I agree with Torsten, when I use openOrThrowException, I'm using the String parameter to explain why it was ok to use it (sometimes it is a test, sometimes we checked that the box is full just a line abobe it, etc).

@fmpwizard fmpwizard closed this in ac5316b Nov 17, 2012
@fmpwizard fmpwizard reopened this Nov 17, 2012
@fmpwizard fmpwizard closed this in 9281228 Nov 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment