New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email composing for attaches #1403

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@limansky
Copy link
Contributor

limansky commented Jan 22, 2013

Hi!

Current implementation of e-mail composing put all of the mail parts into one multipart/related part. As result Ms Outlook (and possible some other mail clients) doesn't show attachment.

The idea of this fix is put all inline attachments into multipart/related part and, the other ones are placed in multipart/mixed part (togeher with multipart/related part). I've tested both images and attachments (I used pdf) with Outlook 2010 - all works for me.

@dpp

This comment has been minimized.

Copy link
Member

dpp commented Jan 22, 2013

-1

This changes the behavior. The current behavior is necessary if you want to include images in an HTML message.

I'm all for new additional behavior, but silently changing behavior is not good.

@limansky

This comment has been minimized.

Copy link
Contributor Author

limansky commented Jan 22, 2013

Maybe I described it ambiguously, but actually it doesn't change current behavior. The images are still placed in multipart/related message part, so inline images are located properly (at least in Outlook).

So, in case if both attachments and inline images are available the MIME structure will be:
multipart/mixed start
multipart/related start
text/html
image
image...
multipart/related end
attachment
multipart/mixed end

@limansky

This comment has been minimized.

Copy link
Contributor Author

limansky commented Jan 22, 2013

BTW, I've checked gmail web interface as a reference implementation. It's works the same way (with exception, that it also added multipart/alternative mime part to add plain text body).

@nafg

This comment has been minimized.

Copy link
Contributor

nafg commented Jan 23, 2013

I wonder if something like http://litmus.com/ or http://www.campaignmonitor.com/testing/ could help.

@farmdawgnation

This comment has been minimized.

Copy link
Member

farmdawgnation commented May 19, 2013

So, this pull request has been open for 4 months, and there's been no movement on it. Seeing as there appears to be some dispute over whether or not this implementation is desired, perhaps this PR should be closed until such a time as an agreement is reached?

@limansky

This comment has been minimized.

Copy link
Contributor Author

limansky commented May 19, 2013

It would be nice if someone have problems described in the https://www.assembla.com/spaces/liftweb/tickets/1197-improve-mailer-functionality-for-attachments…#/activity/ticket: test the patch.
As for me, we are just have class derived from Mailer with this patch in our project. Now it's in production for several months, and there are no issues (at least we don't know about it).

@farmdawgnation

This comment has been minimized.

Copy link
Member

farmdawgnation commented May 27, 2014

Ok, this is over a year old at this point. I'm going to take this over and see if I can't make heads or tails of whether or not it works or breaks anything and open my own PR. If sending attachments is broken for some Outlooks that's something we should try to un-break in 2.6 if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment