Rename ComputeTransformRules->CanBind, #{computeTransform->apply} #1407

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

Contributor
nafg commented Feb 8, 2013

Rename ComputeTransformRules to CanBind
Rename CTR#computeTransform(x, ns) to CTR#apply(x)(ns)

@nafg nafg was assigned Feb 8, 2013

Lift Web Framework » framework #5 FAILURE
Looks like there's a problem with this pull request
(what's this?)

Contributor
nafg commented Feb 8, 2013

Note that buildhive failed due to OOM, not anything wrong with the code. My own jenkins instance seems to be in the process of building it for 2.9.1 after having sucessfully tested it on 2.10 and 2.9.2.
Can someone tell me who set up buildhive? /cc @indrajitr

Contributor
nafg commented Feb 8, 2013

My Jenkins says "Finished: SUCCESS"

Contributor
nafg commented Feb 8, 2013

After running
LIFTSH_OPTS=-Xmx2g -XX:MaxPermSize=1536m ./liftsh +clean +test +publish-local

Owner

+1

Owner

rebasing to master in less than an hour

Owner

rebased to master

@fmpwizard fmpwizard closed this Feb 15, 2013
Contributor
nafg commented Feb 15, 2013

Thanks!

On Thu, Feb 14, 2013 at 11:49 PM, Diego Medina notifications@github.comwrote:

rebased to master


Reply to this email directly or view it on GitHubhttps://github.com/lift/framework/pull/1407#issuecomment-13592742.

@nafg nafg removed their assignment Apr 7, 2014
@fmpwizard fmpwizard deleted the nafg/renamecanbind branch Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment