New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark S.getHeader as deprecated #1408

Merged
merged 0 commits into from Feb 21, 2013

Conversation

Projects
None yet
5 participants
@Shadowfiend
Member

Shadowfiend commented Feb 10, 2013

It's unclear whether it is a synonym for S.getResponseHeader or S.getRequestHeader (it's the latter).

See https://groups.google.com/forum/#!topic/liftweb/CfxyHi2Ti8I .

@ghost ghost assigned Shadowfiend Feb 10, 2013

@buildhive

This comment has been minimized.

buildhive commented Feb 10, 2013

Lift Web Framework » framework #7 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@fmpwizard

This comment has been minimized.

Member

fmpwizard commented Feb 10, 2013

+1

@farmdawgnation

This comment has been minimized.

Member

farmdawgnation commented Feb 13, 2013

👍 from me.

@fmpwizard

This comment has been minimized.

Member

fmpwizard commented Feb 15, 2013

rebasing to master in less than an hour

@fmpwizard

This comment has been minimized.

Member

fmpwizard commented Feb 15, 2013

rebased to master

@fmpwizard fmpwizard closed this Feb 15, 2013

@nafg nafg reopened this Feb 20, 2013

@buildhive

This comment has been minimized.

buildhive commented Feb 20, 2013

Lift Web Framework » framework #25 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@nafg

This comment has been minimized.

Contributor

nafg commented Feb 20, 2013

Sorry to reopen, would you mind (a) to reverse the order of the @Deprecation arguments -- the version is second, and (b) to replace all uses in the Lift codebase of the deprecated method?
Thanks.

@Shadowfiend

This comment has been minimized.

Member

Shadowfiend commented Feb 20, 2013

Thanks for the heads up; I'll try and get that done today :)

@nafg

This comment has been minimized.

Contributor

nafg commented Feb 21, 2013

Thanks!

On Wed, Feb 20, 2013 at 8:53 AM, Antonio Salazar Cardozo <
notifications@github.com> wrote:

Thanks for the heads up; I'll try and get that done today :)


Reply to this email directly or view it on GitHubhttps://github.com//pull/1408#issuecomment-13832462.

@Shadowfiend Shadowfiend merged commit 5ba3bfe into master Feb 21, 2013

@Shadowfiend

This comment has been minimized.

Member

Shadowfiend commented Feb 22, 2013

All fixed up in #1412; something strange happened to this PR when I force-pushed the branch rebased onto master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment