Log error on AJAX call for non-found function GUID #1427

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants

Shadowfiend added some commits Aug 14, 2013

Add centralized handling for parameters not mapped to Lift functions.
We add a LiftRules entry, handleUnmappedParameter, that is a FactoryMaker that
vends a function to handle any parmaeter not mapped to a Lift function. By
default, the function checks if the parameter name starts with F, and logs a
warning if so. This is to do a quick, high-speed check as to whether or not the
parameter looks like a Lift function binding.
@fmpwizard

This comment has been minimized.

Show comment Hide comment
@fmpwizard

fmpwizard Aug 15, 2013

Member

👍

Member

fmpwizard commented Aug 15, 2013

👍

+ val callback = Box.legacyNullTest(nmessageCallback.get(parameterName))
+
+ if (callback.isEmpty)
+ LiftRules.handleUnmappedParameter.vend(state, parameterName)

This comment has been minimized.

Show comment Hide comment
@farmdawgnation

farmdawgnation Sep 9, 2013

Member

Indentation?

@farmdawgnation

farmdawgnation Sep 9, 2013

Member

Indentation?

This comment has been minimized.

Show comment Hide comment
@Shadowfiend

Shadowfiend Sep 9, 2013

Member

Weird.

@farmdawgnation

This comment has been minimized.

Show comment Hide comment
@farmdawgnation

farmdawgnation Sep 9, 2013

Member

👍

Member

farmdawgnation commented Sep 9, 2013

👍

@fmpwizard

This comment has been minimized.

Show comment Hide comment
@fmpwizard

fmpwizard Sep 14, 2013

Member

on master now

Member

fmpwizard commented Sep 14, 2013

on master now

@fmpwizard

This comment has been minimized.

Show comment Hide comment
@fmpwizard

fmpwizard Sep 15, 2013

Member

and now on lift 3.0 too

Member

fmpwizard commented Sep 15, 2013

and now on lift 3.0 too

@fmpwizard fmpwizard closed this Sep 15, 2013

@fmpwizard fmpwizard deleted the log-unknown-guids branch Sep 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment