Add Box.forall. #1502

Merged
merged 3 commits into from Mar 16, 2014

Conversation

Projects
None yet
3 participants

vn971 commented Nov 10, 2013

As well a couple of cleanup tasks.

Vasya Novikov code clean-up f30a184
Owner

fmpwizard commented Nov 10, 2013

does it compile fine on scala 2.9.1 ?
Sometimes those weird things were needed in older versions of Scala but 2.10 doesn't need them

Owner

fmpwizard commented Nov 10, 2013

just in case you haven't done that before, from inside sbt you can do

++2.9.1 to go into that version and then you can simply call compile

Thanks

vn971 commented Nov 10, 2013

Thanks for the precise instruction. I've never compiled lift/framefork before, but I've done it now:

  • loaded system-wide SBT (which is 0.13.0)
  • set ++2.9.1
  • [dowloaded this Scala version]
  • compiled successfully
[warn] there were 1 unchecked warnings; re-run with -unchecked for details
[warn] one warning found
[warn] there were 16 unchecked warnings; re-run with -unchecked for details
[warn] one warning found
[warn] there were 167 unchecked warnings; re-run with -unchecked for details
[warn] three warnings found
[info] Compiling 2 Scala sources to /home/vasya/data/dev/lift-framework/persistence/ldap/target/scala-2.9.1/classes...
[success] Total time: 343 s, completed Nov 11, 2013 1:13:15 AM

vn971 commented Dec 23, 2013

OK, all tests pass now. Please reconsider the PR (it's done according to CONTRIBUTORS.md now).

@fmpwizard fmpwizard commented on an outdated diff Dec 23, 2013

...ommon/src/test/scala/net/liftweb/common/BoxSpec.scala
@@ -239,6 +245,10 @@ class BoxSpec extends Specification with ScalaCheck with BoxGenerator {
val empty: Box[Int] = Empty
empty exists {_ > 0} must beFalse
}
+ "define a 'forall' method returning false" in {
@fmpwizard

fmpwizard Dec 23, 2013

Owner

do you mean return true ?

Owner

fmpwizard commented Dec 23, 2013

Could you also add test for a Failure box?

vn971 commented Dec 23, 2013

@fmpwizard right, my mistake about the "return false" phrase.
About Failure -- yes, I'll add it (thought about it after the commit, too).

Owner

Shadowfiend commented Jan 16, 2014

This looks good; I'll give it a whirl and try to merge it tonight.

Shadowfiend merged commit 1234b96 into lift:master Mar 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment