New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memoize declared fields to avoid reflection during case class decomposition #1517

Merged
merged 1 commit into from Feb 15, 2014

Conversation

Projects
None yet
3 participants
@chriswebster
Copy link

chriswebster commented Feb 1, 2014

This change uses the memoize pattern in Meta to cache class fields avoiding reflection on subsequent calls.

The change discussion on the mailing list:
https://groups.google.com/forum/#!topic/liftweb/O9DDgSZqkkc

Contributor file signature:
https://github.com/lift/framework/blob/master/contributors.md#name-23

@Shadowfiend

This comment has been minimized.

Copy link
Member

Shadowfiend commented Feb 2, 2014

Haven't had a chance to take this for a spin yet, but it looks good.

@Shadowfiend

This comment has been minimized.

Copy link
Member

Shadowfiend commented Feb 7, 2014

👍

@farmdawgnation

This comment has been minimized.

Copy link
Member

farmdawgnation commented Feb 15, 2014

Gonna give this guy a test right quick like.

@farmdawgnation

This comment has been minimized.

Copy link
Member

farmdawgnation commented Feb 15, 2014

Change looks simple enough; specs are passing in 2.9.1-2.10... let's get this guy in.

farmdawgnation added a commit that referenced this pull request Feb 15, 2014

Merge pull request #1517 from chriswebster/master
Memoize declared fields to avoid reflection during case class decomposition.

@farmdawgnation farmdawgnation merged commit 1da8516 into lift:master Feb 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment