Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upunexpected WARN while using `with-resource-id`, lift-3.0-SNAPSHOT #1521
Conversation
Shadowfiend
added some commits
Mar 15, 2014
This comment has been minimized.
This comment has been minimized.
Any feedback here? |
This comment has been minimized.
This comment has been minimized.
Ah, sorry, I forgot about the PR/issue, only replied in the mailing list. The issue can be closed. Thank you very much! |
vn971
closed this
Mar 29, 2014
This comment has been minimized.
This comment has been minimized.
Heh, um, no, the functionality still needs to land in the repository. I was asking about feedback regarding the code, from other committers ;) |
Shadowfiend
reopened this
Mar 29, 2014
fmpwizard
added this to the 2.6-M3 milestone
Mar 29, 2014
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Curious: Is there some spec we could add to demonstrate the fixed behavior or no? |
This comment has been minimized.
This comment has been minimized.
Not that I can think of, no. Partly because it's not “fixed” so much as “different”. It's not really a bug that it was behaving as it was, just a slight change of behavior to reflect the way the unmapped parameter warnings work. I mean, we could write a spec that attachResourceId adds a resource that is prefixed by |
This comment has been minimized.
This comment has been minimized.
Alright. I'm down. Gonna double check that compile and those tests then party. |
Shadowfiend commentedMar 15, 2014
Mailing list topic: https://groups.google.com/forum/#!msg/liftweb/z5rKAxR0y08/S811GG3BLmsJ
The actual bug is with having a WARNing:
01:50:52.564 WARN [qtp1170205978-851126 - /img/favicon.png?F1171910628180AB1FAH=_] net.liftweb.http.LiftRules - Unmapped Lift-like parameter seen in request [/img/favicon.png]: F1171910628180AB1FAH