Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Move ConnectionIdentifier to util package. #1556
I also replaced the use of MongoIdentifier with ConnectionIdentifier.
Then, I added RecordRules.fieldName that takes a ConnectionIdentifier as an argument. I had to add
One question: DefaultConnectionIdentifier.jndiName was defined as a
After I did this I realized we don't necessarily need to deprecate db.ConnectionIdentifier. We could just leave the type alias the same way mapper is.
added a commit
this pull request
May 4, 2014
Often it is checked via....
def jndiJdbcConnAvailable_? : Boolean = jndiConnection(DefaultConnectionIdentifier).isDefined
This suggests to me we need a version of
If a different
I failed to find anything in the wiki showing an example of setting the
In any case, I don't think it'd be too late to change it back. Also, although I've never used the DB stuff, I would agree that a version of
It looks like there's only one mention on the wiki, right at the end of the page on PostgresSQL. That's not a problem. My concern is only that it's a way of working that's already in use, and I'd like to understand the impact for users to change.
I have a couple of app that uses the JNDI thing: for Mapper and Squeryl . I'll go through a port exercise and see what we a user needs to do to get to the custom
That aside: it's a breaking change. Deprecated and scheduled for termination in 3.0?
Since nobody responded to my question on this PR (to be fair it was kind of buried) I just left it in.
At this point we should probably just revert that change, I just hope that doesn't mess up the 2.6 RC cycle.
BTW, I was able to get my Mapper app converted over to use a custom
For future reference/migration, it looks like the steps are:
Thanks for posting them Richard, I didn't want them to be lost in the PR so I added them here https://www.assembla.com/spaces/liftweb/wiki/Cool_Tips#custom_connectionidenfitier .
I think it may be useful to add them a comments to the code if we go and deprecate it